Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61017
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nG8fRMbqe2syW_7xbDKHbOPvqG5F3hO3HMyR=JY0RELyw@mail.gmail.com>
References: <CAAyV7nH6FCZUqrirJ0uOApuwR64Cky3cVnRfbrcjkZrpOKiN6w@mail.gmail.com>
	<1340815507.2802.9.camel@guybrush>
	<CAAyV7nG8fRMbqe2syW_7xbDKHbOPvqG5F3hO3HMyR=JY0RELyw@mail.gmail.com>
Date: Thu, 28 Jun 2012 10:45:22 +0200
Message-ID: <CAEZPtU6EHDLK3BUcT5Te=hHZPKnaMozp+w5=PKufvJ9nFVcR+A@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [DRAFT RFC] Adding Simplified Password Hashing API
From: pierre.php@gmail.com (Pierre Joye)

Hi Anthony!

On Thu, Jun 28, 2012 at 4:00 AM, Anthony Ferrara <ircmaxell@gmail.com> wrot=
e:

> Hrm. Well, then I guess I could re-implement against crypt internally.
> That would take either a slight re-implementation of the crypt()
> internals, or slight refactoring of the PHP_FUNCTION(crypt) function
> to enable c calls to it (even if it's disabled).

We would have to expose the crypt implementation, it is not the case
right now. But you could still use it using func call.

Let me know if you need to expose it and which parts, we will need to
refactor it a bit (which should be a good thing to do anyway).

> I don't like the concept of core functions disappearing if they are
> not implemented.

Well, that's the case for extensions altogether so... :)

However if I remember correctly, I made crypt always available from
php 5.3 and later, for all algorithms.

>> =A0 =A0E_WARNING - When supplied an incorrect number of arguments.
>> =A0 =A0E_WARNING - When supplied a non-string first parameter (password)

I would not use warnings at all but return false on error. Maybe add
an argument or a function to fetch the error messages.

In case you call other PHP functions, you can push/pop the errors
easily as well.


Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org