Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61014
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXbXcaMtiFLN+9fhZ=dG4anYPnZgNjVdxoEt2DYPZh=sUQ@mail.gmail.com>
References: <CAAyV7nFciZcsL+AW9W4GbhM+PhM3RhWOJ7G0iBQsEHfSWO2QmA@mail.gmail.com>
 <CAGa2bXbXcaMtiFLN+9fhZ=dG4anYPnZgNjVdxoEt2DYPZh=sUQ@mail.gmail.com>
Date: Thu, 28 Jun 2012 12:45:17 +0900
Message-ID: <CAGa2bXYY8Q8GTm6q194DvtK7G9-pVTwMwBiEKzgsWsp5z0Wx9w@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH - PR] Disable ATTR_EMULATE_PREPARES by default
 for PDO_Mysql
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi,

I forgot to mention MySQL's query cache.
This change may have negative performance impact, since prepared
query is not cached and native prepared query may not be used by
other requests.

It would be nice to have an option keeping prepared statement
when PDOStatement destroyed.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net


2012/6/20 Yasuo Ohgaki <yohgaki@ohgaki.net>:
> Hi,
>
> I'm not opposed to this change, but I would like to give some ideas.
>
> If I use PDO postgresql and prepared statement, it executes native
> prepared query. However, prepared statement is released(removed)
> when PDOStatement object is destroyed.
>
> If PDO MySQL made like this, performance will not increase much
> unless app issues the same SQL query over and over during request.
> It would be nice to have option for not to release prepared query for
> better performance.
>
> BTW, PDO should have method for setting client/database encoding.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
>
> 2012/6/15 Anthony Ferrara <ircmaxell@gmail.com>:
>> Hello all,
>>
>> I raised this topic on list over a year ago (
>> http://marc.info/?l=php-internals&m=130417646507744&w=2 ). It was
>> determined that it wasn't time yet to disable prepared statement
>> emulation for MySQL yet. However, Rasmus did mention that it was a
>> possibility for 5.4 (
>> http://marc.info/?l=php-internals&m=130418875017027&w=2 ). Since that
>> ship has sailed, I submitted a pull request for trunk to change the
>> default value of prepared statement emulation for MySQL.
>>
>> https://github.com/php/php-src/pull/108
>>
>> https://bugs.php.net/bug.php?id=54638
>>
>> Does this need to be an RFC (should I draft one)? Or can it just be
>> pulled as-is?
>>
>> Thanks,
>>
>> Anthony
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>