Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61006
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain oracle.com designates 141.146.126.227 as permitted sender)
Message-ID: <4FEB5060.7050301@oracle.com>
Date: Wed, 27 Jun 2012 11:26:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: OISHI Kazuo <kazuo@o-ishi.jp>
CC: internals@lists.php.net
References: <4FAF1EE5.5010409@sugarcrm.com> <4FDA8833.1040408@gmail.com> <874nqdnnas.fsf@molech.giraffy.jp> <4FE364D8.9000204@oracle.com> <8762ajq0vp.fsf@molech.giraffy.jp> <4FEA5059.2050009@oracle.com> <87k3ytfleo.fsf@molech.giraffy.jp>
In-Reply-To: <87k3ytfleo.fsf@molech.giraffy.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] bug 54547
From: christopher.jones@oracle.com (Christopher Jones)



On 06/26/2012 09:06 PM, OISHI Kazuo wrote:
>> Does this need an architecture specific SKIPIF?  See the mention of
>> PHP_INT_SIZE on http://qa.php.net/write-test.php
>
> Like this?
> ===============================================================
> --SKIPIF--
> <?php
> if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platforms only");
> ?>
> ===============================================================
>
>

Yes - if your test is for 64 bit platforms.  If other conditions
affect the output (endianess etc?) then you should add other tests
to the SKIPIF section.

Can you also create another PHPT file for 32 bit platforms, if there
isn't one already?

> I'm afraid I may miss your point.
>
>>>> Can you add some phpt tests for all the cases you've raised?
>
> Could you tell me your intention of this question?

So that next time this code changes any breakage is obvious.

>
>
>> I don't know whether to suggest adding an XFAIL for 5.4, or whether to
>> suggest changing the expected output.  This would depend on whether
>> there is likely to be any code change to 5.4 or not.
>
> Sorry, I cannot understand what you say, but PHP code changes
> from 5.4.3 to 5.4.4 for #54547 and #62097 are:
>
>   https://github.com/php/php-src/commit/9344bf193c6e35c8706923953f3e63bb01cc05ed
>   https://github.com/php/php-src/commit/acd711685a592c52be200e248154283c6c49c9f8
>
> zendi_smart_strcmp() and is_numeric_string[_ex]() are changed.
>

Any test you create for PHP 5.4 need to either:

1. Pass, or
2. have an XFAIL section

I don't know whether or not PHP 5.4 is going to be changed. If it is not
going to be changed, then you should do #1.

Chris

-- 
christopher.jones@oracle.com
http://twitter.com/#!/ghrd