Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60978
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1340788691.2802.0.camel@guybrush>
References: <CAEZPtU5qbiv4e-7pfPx84EDAJnRoA3OUUxPa_55XyA_ZNJYR9A@mail.gmail.com>
	<4FEAABE5.5090908@sugarcrm.com>
	<1340788691.2802.0.camel@guybrush>
Date: Wed, 27 Jun 2012 11:23:38 +0200
Message-ID: <CAEZPtU41FQKHZ9Y1vqdn3w-oTiTjp7Tj_iuGoCY2kRQYQNF5gw@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, PHP internals <internals@lists.php.net>, 
	David Soria Parra <dsp@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: #61421 for 5.3/4
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Jun 27, 2012 at 11:18 AM, Johannes Schl=FCter
<johannes@schlueters.de> wrote:
> On Tue, 2012-06-26 at 23:44 -0700, Stas Malyshev wrote:
>> Hi!
>>
>> > I would like to merge the patch from #61421 to all active branches (RM=
s as CC).
>> >
>> > It is not a new function nor does it add new features but new
>> > constants to support more algorithms for the signature verification.
>>
>> Don't see any problem with it.
>
> It's a feature .. but acceptable -)

Not per se, a grey area where only adding constants could be fine.
Anything else or more complicated is not. But why I ask :)

Waiting David's reply and then I will merge it.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org