Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60973
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain giraffy.jp from 210.172.133.182 cause and error)
To: Christopher Jones <christopher.jones@oracle.com>
Cc: internals@lists.php.net
In-Reply-To: <4FEA5059.2050009@oracle.com> (Christopher Jones's message of
	"Tue, 26 Jun 2012 17:14:17 -0700")
References: <4FAF1EE5.5010409@sugarcrm.com> <4FDA8833.1040408@gmail.com>
	<874nqdnnas.fsf@molech.giraffy.jp> <4FE364D8.9000204@oracle.com>
	<8762ajq0vp.fsf@molech.giraffy.jp> <4FEA5059.2050009@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
Date: Wed, 27 Jun 2012 13:06:55 +0900
Message-ID: <87k3ytfleo.fsf@molech.giraffy.jp>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PHP-DEV] bug 54547
From: kazuo@o-ishi.jp (OISHI Kazuo)

> Does this need an architecture specific SKIPIF?  See the mention of
> PHP_INT_SIZE on http://qa.php.net/write-test.php

Like this?
===============================================================
--SKIPIF--
<?php
if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platforms only");
?>
===============================================================


I'm afraid I may miss your point.

>>> Can you add some phpt tests for all the cases you've raised?

Could you tell me your intention of this question?


> I don't know whether to suggest adding an XFAIL for 5.4, or whether to
> suggest changing the expected output.  This would depend on whether
> there is likely to be any code change to 5.4 or not.

Sorry, I cannot understand what you say, but PHP code changes
from 5.4.3 to 5.4.4 for #54547 and #62097 are:

 https://github.com/php/php-src/commit/9344bf193c6e35c8706923953f3e63bb01cc05ed
 https://github.com/php/php-src/commit/acd711685a592c52be200e248154283c6c49c9f8

zendi_smart_strcmp() and is_numeric_string[_ex]() are changed.

-- 
OISHI Kazuo