Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60968
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain liip.ch designates 207.126.144.139 as permitted sender)
Sender: Christian Stocker <chregu@liip.ch>
Message-ID: <4FE98704.2050106@php.net>
Date: Tue, 26 Jun 2012 11:55:16 +0200
Reply-To: christian.stocker@liip.ch
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Lior Kaplan <lior.k@zend.com>
CC: internals@lists.php.net
References: <1340614126.32207.13.camel@pc-liork>
In-Reply-To: <1340614126.32207.13.camel@pc-liork>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: Non ASCII char in php.ini [patch]
From: christian.stocker@liip.ch (Christian Stocker)

Hi

Yeah, that looks very wrong. Do you want to commit it or should I?

chregu

On 25.06.12 10:48, Lior Kaplan wrote:
> Hi,
> 
> We've noticed that the php.ini-development and php.ini-production
> include a UTF-8 character which looks weird under ASCII (or other
> "simple" locales).
> 
> It was added with this commit to the PHP-5.3 branch:
> http://git.php.net/?p=php-src.git;a=patch;h=c9b5d92821db7335632f8578871e2b75ac018f2a
> 
> (It doesn't exist in PHP-5.4/master branches)
> 
> diff --git a/php.ini-development b/php.ini-development
> index 1375516..d1fa7a3 100644
> --- a/php.ini-development
> +++ b/php.ini-development
> @@ -1909,7 +1909,7 @@ ldap.max_links = -1
>  
>  [xsl]
>  ; Write operations from within XSLT are disabled by default.
> -; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK
> |<C2><A0>XSL_SECPREF_WRITE_FILE = 44
> +; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK |
> XSL_SECPREF_WRITE_FILE = 44
>  ; Set it to 0 to allow all operations
>  ;xsl.security_prefs = 44
>  
> diff --git a/php.ini-production b/php.ini-production
> index 495fb01..9d5861d 100644
> --- a/php.ini-production
> +++ b/php.ini-production
> @@ -1909,7 +1909,7 @@ ldap.max_links = -1
>  
>  [xsl]
>  ; Write operations from within XSLT are disabled by default.
> -; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK
> |<C2><A0>XSL_SECPREF_WRITE_FILE = 44
> +; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK |
> XSL_SECPREF_WRITE_FILE = 44
>  ; Set it to 0 to allow all operations
>  ;xsl.security_prefs = 44
>  
> (this is the diff with LC_ALL=c, notice the "<C2><A0>" removal. The
> change isn't visible with UTF-8 locales)
> 
> Thanks,
> 
> Lior Kaplan
> Zend Technologies Ltd.
> 

-- 
Liip AG  //  Feldstrasse 133 //  CH-8004 Zurich
Tel +41 43 500 39 81 // Mobile +41 76 561 88 60
www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE