Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60947 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69162 invoked from network); 23 Jun 2012 19:53:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jun 2012 19:53:06 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.123 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.123 smtp123.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.123] ([67.192.241.123:47134] helo=smtp123.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/90-64697-0AE16EF4 for ; Sat, 23 Jun 2012 15:53:05 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp2.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 719727820C; Sat, 23 Jun 2012 15:53:02 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp2.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id EA919780E3; Sat, 23 Jun 2012 15:53:01 -0400 (EDT) Message-ID: <4FE61E9D.5050908@sugarcrm.com> Date: Sat, 23 Jun 2012 12:53:01 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Nikita Popov CC: Rasmus Lerdorf , Daniel Convissor , PHP internals References: <20120621141241.GA25789@analysisandsolutions.com> <4FE33EDF.2000409@lerdorf.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] json_encode() behavior for incorrectly encoded strings From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > The warning for invalid UTF-8 stays intact and is thrown also with > display_errors = On. If this behavior is undesired this can be remedied > later. Must we discuss it 1000 times anew? There was a reason why it didn't throw warning when display_errors is on. The reason is that it is very easy to feed the server configured with display_errors = on wrong JSON and thus force it to reveal information, and this is largely beyond the control of application writer. But what I am worried about even more is getting back to that "commit first, discuss later" mentality. Why we have again a commit in the stable branch before we have a consensus decision what it should be doing? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227