Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60928
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain oracle.com designates 148.87.113.117 as permitted sender)
Message-ID: <4FE364D8.9000204@oracle.com>
Date: Thu, 21 Jun 2012 11:15:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: OISHI Kazuo <kazuo@o-ishi.jp>
CC: internals@lists.php.net
References: <4FAF1EE5.5010409@sugarcrm.com> <4FDA8833.1040408@gmail.com> <874nqdnnas.fsf@molech.giraffy.jp>
In-Reply-To: <874nqdnnas.fsf@molech.giraffy.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] bug 54547
From: christopher.jones@oracle.com (Christopher Jones)



On 06/14/2012 10:42 PM, OISHI Kazuo wrote:
>>> I know this was discussed a number of times here, but just to bring it
>>> to a conclusion - I intend to apply patch in the bug report - which
>>> removes conversion for strings that do not convert to integers - to 5.4.
>>> If anybody sees anything that breaks because of this please tell.
>>
>> "12345678901234567890" == "12345678901234567890.0"
>>
>> used to be true, is now false ... i'd still say that's ok though as
>> it is a case of "never compare floats for equality" here, now that
>> the decimal clearly says that at least the right side is supposed
>> to be float, not integer ...
>
> In addition to == operator, >, <, >=, and <= operators are influenced.
>
> And, hexdecimal format for big number is now case-sensitive.
>
> http://www.mail-archive.com/internals@lists.php.net/msg58789.html
>

Can you add some phpt tests for all the cases you've raised?

Chris

-- 
christopher.jones@oracle.com
http://twitter.com/#!/ghrd