Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60922 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 61919 invoked from network); 21 Jun 2012 12:37:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jun 2012 12:37:10 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gh0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:62279] helo=mail-gh0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 04/A3-42253-47513EF4 for ; Thu, 21 Jun 2012 08:37:09 -0400 Received: by ghbg2 with SMTP id g2so437753ghb.29 for ; Thu, 21 Jun 2012 05:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bePXGQlkl3mYFBFMDm/lRNGKJdYftdIrx2/T4TLwzbA=; b=EwdAtCKpu2+R0I1GxdEYG8PqvBl3KG/YU6Lp22Z5oq9V2ywJBt2nRwe+N2YfpL+7Ih 4g3O6NqIWuXLQxnHorsBG+lykUiV+y+cBcFEoUGXE9BNEporYSsi12kJWURBwvs4CNps YUL1PuOseZWSIaMpaH8dDAK9R3fXdlWhdzWgRolc8yXJTeiUURO8j9HoYAbbl5oUkKM9 hmtN8ohsQ0qU4EB2GPKCfand1JRbmc9oUvw3H3/YwY+BJwVNAFIkiXs8ymKKP+vtdrNv twhshUwonO4MaNz1aZkSPQILLD+mLauoJ1hz3TOAGQUk+jsRyttchADdXXMHKRv9vBvv SPeg== MIME-Version: 1.0 Received: by 10.236.179.106 with SMTP id g70mr32334738yhm.53.1340282226159; Thu, 21 Jun 2012 05:37:06 -0700 (PDT) Received: by 10.147.113.7 with HTTP; Thu, 21 Jun 2012 05:37:06 -0700 (PDT) In-Reply-To: References: Date: Thu, 21 Jun 2012 14:37:06 +0200 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] json_encode() behavior for incorrectly encoded strings From: pierre.php@gmail.com (Pierre Joye) hi, On Thu, Jun 21, 2012 at 11:21 AM, Nikita Popov wrote: >> 5.3 should be brought in line with 5.4. > So you think that the corrected code should be backed out from PHP 5.3 > and the incorrect 5.4/master behavior be restored? For the warning yes. For the rest, it should imo return false as well, partial encoding or magic replacements make no sense here. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org