Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60918 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46288 invoked from network); 21 Jun 2012 10:21:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jun 2012 10:21:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender) X-PHP-List-Original-Sender: ab@php.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:60011] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/90-42253-BB5F2EF4 for ; Thu, 21 Jun 2012 06:21:50 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id E48976FC225; Thu, 21 Jun 2012 12:21:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 Received: from webmail.klapt.com (h1123647.serverkompetenz.net [127.0.0.1]) by h1123647.serverkompetenz.net (Postfix) with ESMTP id C31736FC032; Thu, 21 Jun 2012 12:21:41 +0200 (CEST) Received: from 94.216.47.138 (SquirrelMail authenticated user anatoliy@belsky.info) by webmail.klapt.com with HTTP; Thu, 21 Jun 2012 12:21:41 +0200 Message-ID: <59545e011ef479e622f90a7104618d03.squirrel@webmail.klapt.com> In-Reply-To: References: Date: Thu, 21 Jun 2012 12:21:41 +0200 To: "Nikita Popov" Cc: internals@lists.php.net Reply-To: ab@php.net User-Agent: SquirrelMail/1.4.21 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Subject: Re: Generators patch From: ab@php.net ("Anatoliy Belsky") Hi Nikita, yep, once you see tsrm_ls it's clear. Just wanted to mention it was tested on windows. ZTS is enabled by default there. It compiles fine now :) but Zend\tests\generators\clone_with_stack.phpt fails on both TS and ZTS builds under win the diff looks like 001+ 001- string(10) "xxxxxxxxxx" and running that php file manually leads to crash and points me to the zend_execute.h at line 335. I didn't debug it in details but could do it later if you have no fail on nix. Cheers Anatoliy Am Mi, 20.06.2012, 21:36 schrieb Nikita Popov: > On Wed, Jun 20, 2012 at 5:25 PM, Anatoliy Belsky wrote: >> Hi Nikita, >> >> I've just tried to compile your generators branch on windows, the build >> is >> broken there. This are the relevant messages before the compilation >> bails >> out: >> >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1543) : error >> C2065: 'tsrm_ls' : undeclared identifier >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1543) : error >> C2065: 'tsrm_ls' : undeclared identifier >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1550) : error >> C2065: 'tsrm_ls' : undeclared identifier >> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio >> 9.0\VC\Bin\cl.exe"' : return code '0x2' >> Stop. > > Hey Anatoliy! > > Thanks for testing the patch :) > The errors aren't really Windows specific, they are there because I > forget to put a few TSRMLS_CC and TSRMLS_DC in the code ^^ (I usually > develop without --enable-maintainer-zts because it makes debugging > easier). > I now fixed the zts errors, so the build should work fine now :) > > Nikita > Those errors aren't Windows specific; they are there because I usually > develop without --enable-maintainer-zts >