Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60900
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nEw5uLC05dz+kqCrFtUJ9yOUeKvR6uZTGo8E6+TjYMoUA@mail.gmail.com>
References: <CAAyV7nEw5uLC05dz+kqCrFtUJ9yOUeKvR6uZTGo8E6+TjYMoUA@mail.gmail.com>
Date: Wed, 20 Jun 2012 11:14:07 +0200
Message-ID: <CAOMtwbRA4aNK-vgnTTGGLEJ9DcWYkVz2++K985O1ARR1Q7XvUA@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function
From: e.zimuel@gmail.com (Enrico Zimuel)

Hi Anthony,

i think your RFC is very good!

I like the idea to have PBKDF2 implementation that is able to act, at
the same time, as secure hash value generator (without the length
parameter) and as key derivation function (with the length parameter).
I think we should be consistent with the API of Hash functions of PHP
and use the raw_output =3D false to generate hex string and raw_output =3D
true to generate  binary output.
If folks need to convert the output to Base64 they can easily use
base64_encode($output) where $output is generated with raw_output =3D
true.
I don't think this is a big deal.
I also agree to insert this function in PHP 5.4, actually in this
implementation we reused other hash functions of PHP and the tests for
PBKDF2 are fully specified in PKCS #5 test vectors that you used in
your patch test.

Very nice job!

Regards,
Enrico

2012/6/19 Anthony Ferrara <ircmaxell@gmail.com>:
> Hello all,
>
> Since there wasn't that much traffic on the draft version of the RFC,
> I've moved it into Proposed.
>
> =A0https://wiki.php.net/rfc/hash_pbkdf2
>
> What are your thoughts?
>
> Thanks,
>
> Anthony
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>