Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60892
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <AB5BAD1A-75BD-4F3D-96D5-BC50E9980043@gmail.com>
References: <CAAyV7nEw5uLC05dz+kqCrFtUJ9yOUeKvR6uZTGo8E6+TjYMoUA@mail.gmail.com>
	<CAJzDObe=FFcq6F9j27NKArGv5eBS0yqttNrFybSnmcyTwwxGQQ@mail.gmail.com>
	<AB5BAD1A-75BD-4F3D-96D5-BC50E9980043@gmail.com>
Date: Tue, 19 Jun 2012 13:35:20 -0400
Message-ID: <CAJzDObfu2vhq4UqV7qafBJuqGj8bicPv+u8yxqfqpzDMdrUApQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function
From: adamjonr@gmail.com (Adam Jon Richardson)

On Tue, Jun 19, 2012 at 6:23 AM, Tjerk Meesters
<tjerk.meesters@gmail.com> wrote:
> On 19 Jun, 2012, at 2:24 PM, Adam Jon Richardson <adamjonr@gmail.com> wrote:
>>
>> One thing I'm wondering about is whether the last parameter could be
>> changed from:
>> raw_output = false
>>
>> To something like:
>> output = "hex" (also allowing output = "raw", output = "base64")
>>
>
> That wouldn't be consistent with the rest of the hash_ family though :)

I agree that keeping the API consistent throughout the hashing family
should be a priority. That said, this function signature is quite
different from the other hash functions. Additionally, the practical
value of this function relates specifically to password storage, and
giving the developer easy, efficient access to more compact storage
strings would likely prove helpful.

Adam