Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60886
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.42 as permitted sender)
References: <CAAyV7nEw5uLC05dz+kqCrFtUJ9yOUeKvR6uZTGo8E6+TjYMoUA@mail.gmail.com> <CAJzDObe=FFcq6F9j27NKArGv5eBS0yqttNrFybSnmcyTwwxGQQ@mail.gmail.com>
In-Reply-To: <CAJzDObe=FFcq6F9j27NKArGv5eBS0yqttNrFybSnmcyTwwxGQQ@mail.gmail.com>
Mime-Version: 1.0 (1.0)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii
Message-ID: <AB5BAD1A-75BD-4F3D-96D5-BC50E9980043@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Date: Tue, 19 Jun 2012 18:23:28 +0800
To: Adam Jon Richardson <adamjonr@gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function
From: tjerk.meesters@gmail.com (Tjerk Meesters)

On 19 Jun, 2012, at 2:24 PM, Adam Jon Richardson <adamjonr@gmail.com> wrote:=


> On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara <ircmaxell@gmail.com> wro=
te:
>>  https://wiki.php.net/rfc/hash_pbkdf2
>>=20
>> What are your thoughts?
>=20
> That's very nice, indeed.
>=20
> One thing I'm wondering about is whether the last parameter could be
> changed from:
> raw_output =3D false
>=20
> To something like:
> output =3D "hex" (also allowing output =3D "raw", output =3D "base64")
>=20

That wouldn't be consistent with the rest of the hash_ family though :)


> Just thinking that most of the time I'd prefer storing the hashed
> passwords as base64-encoded strings just because it's more compact,
> but this isn't a big deal, just a thought.
>=20
> Really nice work!
>=20
> Adam
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20