Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60885 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25819 invoked from network); 19 Jun 2012 06:24:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2012 06:24:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=adamjonr@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=adamjonr@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender) X-PHP-List-Original-Sender: adamjonr@gmail.com X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:34971] helo=mail-ob0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 98/90-20693-72B10EF4 for ; Tue, 19 Jun 2012 02:24:39 -0400 Received: by obfk16 with SMTP id k16so2110872obf.29 for ; Mon, 18 Jun 2012 23:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=3Dg2Rba91Teuu2QdO7opg3l0p7Y6H2Ijuz5VaZmN1kU=; b=PpetD8tNEx7liAOVDC2X1qtILcezGL/CyGUe2xNifNYGPYYARNcrgKPmB5hrjGLW/J 1lXTplatBvRK8nnfM/LSO8dM2ODbcONhUzYyf2ga9S38XgBZrVUqtnGowGqPCUy95Ly8 4C8F6w0tuX7CKOg18mcPKYAV0EgqTAdEyQcsTxoYWOcR4ynXSe1fpdSMGZu7QzTJtOXL Udz9Qm7JU2yTXJEHy3TFEpLHRJe3sqYbyEy/U9mmfTATxGVX8JrGmUO8FEGuSqHG39R/ gWFLaMm2P0ORh4KpKohOXbsP5YqoYIdJk/zC5hkmNhXV3Qs/g6hWp4pC/kfgEwAm/Q0R MP9g== MIME-Version: 1.0 Received: by 10.182.179.38 with SMTP id dd6mr18498116obc.16.1340087076235; Mon, 18 Jun 2012 23:24:36 -0700 (PDT) Received: by 10.182.181.36 with HTTP; Mon, 18 Jun 2012 23:24:36 -0700 (PDT) In-Reply-To: References: Date: Tue, 19 Jun 2012 02:24:36 -0400 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] Add hash_pbkdf2 function From: adamjonr@gmail.com (Adam Jon Richardson) On Mon, Jun 18, 2012 at 7:14 PM, Anthony Ferrara wrot= e: > =A0https://wiki.php.net/rfc/hash_pbkdf2 > > What are your thoughts? That's very nice, indeed. One thing I'm wondering about is whether the last parameter could be changed from: raw_output =3D false To something like: output =3D "hex" (also allowing output =3D "raw", output =3D "base64") Just thinking that most of the time I'd prefer storing the hashed passwords as base64-encoded strings just because it's more compact, but this isn't a big deal, just a thought. Really nice work! Adam