Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60853
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FDB7726.8030008@oracle.com>
References: <CAAyV7nFciZcsL+AW9W4GbhM+PhM3RhWOJ7G0iBQsEHfSWO2QmA@mail.gmail.com>
	<4FDB5604.5000704@oracle.com>
	<4FDB62C2.6090702@oracle.com>
	<CAAyV7nGjUZZvS2=tFRow3sPW+-DtfWsYx+FWWMqg+V-x1vLM8g@mail.gmail.com>
	<4FDB6AFD.2030200@oracle.com>
	<CAAyV7nEZ7LgP-9ZxBY3tEjU9Oac6667mBo9cDgwdwB7=tzL5CQ@mail.gmail.com>
	<4FDB7726.8030008@oracle.com>
Date: Fri, 15 Jun 2012 15:15:57 -0400
Message-ID: <CAAyV7nE__0QTHF6TCqJpgXb4aOKD6k7C5_aOJOzuNpZECY4_cA@mail.gmail.com>
To: Ulf Wendel <ulf.wendel@oracle.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH - PR] Disable ATTR_EMULATE_PREPARES by default
 for PDO_Mysql
From: ircmaxell@gmail.com (Anthony Ferrara)

Ulf,

My apologies. I mis-interpreted that reply.

I would commit, but I do not have commit access (no karma at all). I'm
going away for a few days, but when I get back I will send a separate
request to the list for karma.

Thanks,

Anthony

On Fri, Jun 15, 2012 at 1:55 PM, Ulf Wendel <ulf.wendel@oracle.com> wrote:
> Am 15.06.2012 19:31, schrieb Anthony Ferrara:
>
>> Ulf,
>>>>>
>>>>> It needs an RFC because it needs to document whether or not the other
>>>>> DB drivers should also be changed.
>>>>
>>>>
>>>>
>>>> It's a PDO driver-specific change. So to me it's fairly straight
>>>> forward to see that no other drivers need changing... It doesn't even
>>>> hit the mysql API level...
>>>>
>>>> Not saying an RFC isn't needed, just that justification isn't clear to
>>>> me...
>>>
>>>
>>>
>>> Go commit if you feel like the change is widely accepted, you are willi=
ng
>>> to
>>> explain the differences to users and no test breaks. After all its a
>>> tiny,
>>> little PDO driver default setting.
>>
>>
>> I think you interpreted me wrong. I was just pointing out that this
>> change would be localized to the PDO_MySQL driver. And that
>> documenting whether other DB drivers should be changed is a moot
>> point, since they already aren't using emulation by default...
>>
>> And where did the passive-agressive thing hit off? I posted it to list
>
>
> There's a bug/feature request. Not just one, many came up over the years.
> You wrote a patch. You proposed a change. Nobody rejected the change - fo=
r a
> year. Its a tiny change of a driver default setting. It does not require =
an
> RFC.
>
> One of the maintainers, me, didn't bring up any objections. I said what a=
ny
> maintainer has to say:
>
> =A0- educate users, be aware of the consequences
> =A0- make sure not to break any tests
>
> Another maintainer, Johannes, didn't say "no" a year ago. Nobody says "no=
",
> !no ~ go - its your call. Stand in for your proposal, take care of the te=
sts
> and commit.
>
>
> Ulf
>
>
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>