Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60852
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain oracle.com designates 148.87.113.117 as permitted sender)
Message-ID: <4FDB7726.8030008@oracle.com>
Date: Fri, 15 Jun 2012 19:55:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAAyV7nFciZcsL+AW9W4GbhM+PhM3RhWOJ7G0iBQsEHfSWO2QmA@mail.gmail.com> <4FDB5604.5000704@oracle.com> <4FDB62C2.6090702@oracle.com> <CAAyV7nGjUZZvS2=tFRow3sPW+-DtfWsYx+FWWMqg+V-x1vLM8g@mail.gmail.com> <4FDB6AFD.2030200@oracle.com> <CAAyV7nEZ7LgP-9ZxBY3tEjU9Oac6667mBo9cDgwdwB7=tzL5CQ@mail.gmail.com>
In-Reply-To: <CAAyV7nEZ7LgP-9ZxBY3tEjU9Oac6667mBo9cDgwdwB7=tzL5CQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH - PR] Disable ATTR_EMULATE_PREPARES by default
 for PDO_Mysql
From: ulf.wendel@oracle.com (Ulf Wendel)

Am 15.06.2012 19:31, schrieb Anthony Ferrara:
> Ulf,
>>>> It needs an RFC because it needs to document whether or not the other
>>>> DB drivers should also be changed.
>>>
>>>
>>> It's a PDO driver-specific change. So to me it's fairly straight
>>> forward to see that no other drivers need changing... It doesn't even
>>> hit the mysql API level...
>>>
>>> Not saying an RFC isn't needed, just that justification isn't clear to
>>> me...
>>
>>
>> Go commit if you feel like the change is widely accepted, you are willing to
>> explain the differences to users and no test breaks. After all its a tiny,
>> little PDO driver default setting.
>
> I think you interpreted me wrong. I was just pointing out that this
> change would be localized to the PDO_MySQL driver. And that
> documenting whether other DB drivers should be changed is a moot
> point, since they already aren't using emulation by default...
>
> And where did the passive-agressive thing hit off? I posted it to list

There's a bug/feature request. Not just one, many came up over the 
years. You wrote a patch. You proposed a change. Nobody rejected the 
change - for a year. Its a tiny change of a driver default setting. It 
does not require an RFC.

One of the maintainers, me, didn't bring up any objections. I said what 
any maintainer has to say:

  - educate users, be aware of the consequences
  - make sure not to break any tests

Another maintainer, Johannes, didn't say "no" a year ago. Nobody says 
"no", !no ~ go - its your call. Stand in for your proposal, take care of 
the tests and commit.

Ulf