Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60851
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FDB6AFD.2030200@oracle.com>
References: <CAAyV7nFciZcsL+AW9W4GbhM+PhM3RhWOJ7G0iBQsEHfSWO2QmA@mail.gmail.com>
	<4FDB5604.5000704@oracle.com>
	<4FDB62C2.6090702@oracle.com>
	<CAAyV7nGjUZZvS2=tFRow3sPW+-DtfWsYx+FWWMqg+V-x1vLM8g@mail.gmail.com>
	<4FDB6AFD.2030200@oracle.com>
Date: Fri, 15 Jun 2012 13:31:59 -0400
Message-ID: <CAAyV7nEZ7LgP-9ZxBY3tEjU9Oac6667mBo9cDgwdwB7=tzL5CQ@mail.gmail.com>
To: Ulf Wendel <ulf.wendel@oracle.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH - PR] Disable ATTR_EMULATE_PREPARES by default
 for PDO_Mysql
From: ircmaxell@gmail.com (Anthony Ferrara)

Ulf,
>>> It needs an RFC because it needs to document whether or not the other
>>> DB drivers should also be changed.
>>
>>
>> It's a PDO driver-specific change. So to me it's fairly straight
>> forward to see that no other drivers need changing... It doesn't even
>> hit the mysql API level...
>>
>> Not saying an RFC isn't needed, just that justification isn't clear to
>> me...
>
>
> Go commit if you feel like the change is widely accepted, you are willing to
> explain the differences to users and no test breaks. After all its a tiny,
> little PDO driver default setting.

I think you interpreted me wrong. I was just pointing out that this
change would be localized to the PDO_MySQL driver. And that
documenting whether other DB drivers should be changed is a moot
point, since they already aren't using emulation by default...

And where did the passive-agressive thing hit off? I posted it to list
as a question and a suggestion. I didn't say "let's just do it, who
cares". I didn't say anything about any of the points that were
raised, I just wanted to clarify something that I thought was
miscommunicated. You brought up some very valid points. Points that
shouldn't be ignored. I just haven't addressed them because I haven't
wrapped my head around them fully yet...

So in short, can we please take it down a notch?

Anthony