Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60802
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1206121317310.4834@whisky.home.derickrethans.nl>
References: <CAAyV7nHrmZWXUGnzog44kba35Fap38jaCptecRFjessWFHu74w@mail.gmail.com>
	<alpine.DEB.2.02.1206121317310.4834@whisky.home.derickrethans.nl>
Date: Tue, 12 Jun 2012 08:45:14 -0400
Message-ID: <CAAyV7nGO76dP6NnvuTZ54eY3RuvkucNfSwW=uJJ707sHxEbt6w@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PBKDF2 addition to OpenSSL - Why Not Hash?
From: ircmaxell@gmail.com (Anthony Ferrara)

Derick,

>> I noticed that yesterday a patch was committed to trunk to add PBKDF2
>> support to the OpenSSL extension. =A0I also noted that in the commit
>> message, the author indicated that he would have rather added it to
>> the hash extension, but wasn't able to.
>
> Why wasn't he been able to?

I haven't spoken to him, but here's part of his original commit
message ( https://github.com/php/php-src/commit/f4847efc5d58b3375fa0f326915=
8d5e6ab625c21
)

No easy way to put these in the hash extension since we don't really
support optional
parameters to certain algorithms. Implemented in openssl for now since
it has it already
and is pretty stable.

> Doesn't hurt to have it in both of course... So sure.

Ok, I'll add it to my list to forward port it to git and submit the PR...

Anthony