Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60801
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
Date: Tue, 12 Jun 2012 13:18:16 +0100 (BST)
To: Anthony Ferrara <ircmaxell@gmail.com>
cc: internals@lists.php.net
In-Reply-To: <CAAyV7nHrmZWXUGnzog44kba35Fap38jaCptecRFjessWFHu74w@mail.gmail.com>
Message-ID: <alpine.DEB.2.02.1206121317310.4834@whisky.home.derickrethans.nl>
References: <CAAyV7nHrmZWXUGnzog44kba35Fap38jaCptecRFjessWFHu74w@mail.gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] PBKDF2 addition to OpenSSL - Why Not Hash?
From: derick@php.net (Derick Rethans)

On Tue, 12 Jun 2012, Anthony Ferrara wrote:

> Hello all,
> 
> I noticed that yesterday a patch was committed to trunk to add PBKDF2
> support to the OpenSSL extension.  I also noted that in the commit
> message, the author indicated that he would have rather added it to
> the hash extension, but wasn't able to.

Why wasn't he been able to?

> I had added a patch back in January for that very feature (adding
> PBKDF2 to Hash). https://bugs.php.net/bug.php?id=60813
> 
> Personally, I'd MUCH rather see it in hash(), as it's enabled on far
> more installs (every one) than openssl,  Because of this, I think it
> would be far more useful to add it to hash.
> 
> Should I create a pull request for this, to implement it in hash
> instead of OpenSSL? What do you think?

Doesn't hurt to have it in both of course... So sure.

Derick