Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60800
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
Date: Tue, 12 Jun 2012 08:01:38 -0400
Message-ID: <CAAyV7nHrmZWXUGnzog44kba35Fap38jaCptecRFjessWFHu74w@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: PBKDF2 addition to OpenSSL - Why Not Hash?
From: ircmaxell@gmail.com (Anthony Ferrara)

Hello all,

I noticed that yesterday a patch was committed to trunk to add PBKDF2
support to the OpenSSL extension.  I also noted that in the commit
message, the author indicated that he would have rather added it to
the hash extension, but wasn't able to.

I had added a patch back in January for that very feature (adding
PBKDF2 to Hash). https://bugs.php.net/bug.php?id=60813

Personally, I'd MUCH rather see it in hash(), as it's enabled on far
more installs (every one) than openssl,  Because of this, I think it
would be far more useful to add it to hash.

Should I create a pull request for this, to implement it in hash
instead of OpenSSL? What do you think?

Thanks

Anthony