Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60726
Return-Path: <ab@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 35461 invoked from network); 2 Jun 2012 11:40:10 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Jun 2012 11:40:10 -0000
Authentication-Results: pb1.pair.com header.from=ab@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=ab@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender)
X-PHP-List-Original-Sender: ab@php.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:41501] helo=h1123647.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 1D/B3-45898-A9BF9CF4 for <internals@lists.php.net>; Sat, 02 Jun 2012 07:40:10 -0400
Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006)
	id BA6AB9145A1; Sat,  2 Jun 2012 13:40:06 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	h1123647.serverkompetenz.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.5 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham version=3.3.1
Received: from webmail.klapt.com (h1123647.serverkompetenz.net [127.0.0.1])
	by h1123647.serverkompetenz.net (Postfix) with ESMTP id 24EBA914586;
	Sat,  2 Jun 2012 13:40:05 +0200 (CEST)
Received: from 94.216.44.68
        (SquirrelMail authenticated user anatoliy@belsky.info)
        by webmail.klapt.com with HTTP;
        Sat, 2 Jun 2012 13:40:05 +0200
Message-ID: <118bc4cd407022159c0246a50f6e7305.squirrel@webmail.klapt.com>
In-Reply-To:
 <CADNQb0Vsd_mcui1txh4R8rMAVuQA-J_USJctxL0+e338_wrYAg@mail.gmail.com>
References: <371954f04ec32d79a45a84ac009ca4a8.squirrel@webmail.klapt.com>
    <CA+5g0SKG2-nz4HapVswgRbDKg7S3LCGMYdFBc42mRsY2gPfN2Q@mail.gmail.com>
    <c19c25dedf75a0b41b80531463dd8fe8.squirrel@webmail.klapt.com>
    <CADNQb0Vsd_mcui1txh4R8rMAVuQA-J_USJctxL0+e338_wrYAg@mail.gmail.com>
Date: Sat, 2 Jun 2012 13:40:05 +0200
To: "Hannes Magnusson" <hannes.magnusson@gmail.com>
Cc: ab@php.net,
 "Felipe Pena" <felipensp@gmail.com>,
 internals@lists.php.net
Reply-To: ab@php.net
User-Agent: SquirrelMail/1.4.21
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
Subject: Re: [PHP-DEV] 5.4.3 type hint handling
From: ab@php.net ("Anatoliy Belsky")

Hi Hannes,

ah, now i see. The generator has worked on 5.3 with the erroneous type
hints. But all that IS_LONG turned into "<type>array</type>". And on 5.4
as i've mentioned previously, it gives "unknown typehint" when invoking
the corresponding function. No way around to edit the doc templates
manually though :) .

imho a module shouldn't be allowed to compile when known scalar types are
defined in the arg info. Just to avoid confusion.

Thanks for clearing this guys.

Regards

Anatoliy

On Sat, June 2, 2012 13:04, Hannes Magnusson wrote:
> On Sat, Jun 2, 2012 at 11:41 AM, Anatoliy Belsky <ab@php.net> wrote:
>> Hi Felipe,
>>
>> that's ok but doesn't answer the question with the doc generator :) .
>> Another issue with this were "php --re" where people would want to look
>> at
>> the param list. imho it looks more consistent in 5.3 .
>
> The doc generator only supports array and class typehints.
> Everything else will default to "mixed" (IIRC) and you'll need to edit
> the template afterwards.
>
> These typehints you are trying to use, if allowed, would actually
> reject "10" for IS_LONG before the function would ever be executed. I
> highly doubt that is what you want.
>
> -Hannes
>