Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60710
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
Sender: Maciek Sokolewicz <tularis@gmail.com>
Message-ID: <4FC8C511.9070307@php.net>
Date: Fri, 01 Jun 2012 15:35:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
CC: internals@lists.php.net
References: <ef6e6488aa70f76ccfe540098b54de83@nebm.ist.utl.pt> <4FC80163.3030500@gmail.com> <5a9e29cec281298b330aed14b41dddb9@nebm.ist.utl.pt> <CAEPJduncwgHkXXmjeMwE5Dpt9-ma1iby+WDVjLMvauzwRZJm4A@mail.gmail.com> <CAEZPtU6i6V1LfTAJVWBQwOe8izVtLzpyEcPmSPAtSgpsajo4fA@mail.gmail.com> <272fe309cbfd77b8c2331c9268282d95@nebm.ist.utl.pt>
In-Reply-To: <272fe309cbfd77b8c2331c9268282d95@nebm.ist.utl.pt>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] BreakIterator
From: maciek.sokolewicz@gmail.com (Maciek Sokolewicz)

On 01-06-2012 13:34, Gustavo Lopes wrote:
> On Fri, 1 Jun 2012 12:58:37 +0200, Pierre Joye wrote:
>> On Fri, Jun 1, 2012 at 10:02 AM, Benjamin Eberlei
>> <kontakt@beberlei.de> wrote:
>>> How about IntlBreakIterator? I agree with David that the naming is very
>>> weird, it doesn't hint at something from Intl but another crazy spl
>>> iterator :-)
>
> Asides from date related classes -- which could be confused with stuff
> from ext/date or even ext/calendar --, no other classes have Intl in
> their name. Does SpoofChecker hint at something from intl?
> ResourceBundle? ICU is a rather large library, and while
> internationalization is a common theme, the APIs have diverse
> functionality and therefore diverse names. Plus, SPL does not have a
> monopoly on the *Iterator names.
>
>> I agree too. BreakIterator is a very common name and I suspect
>> possible naming conflicts may happen.
>>
>
> So would you have RuleBasedBreakIterator renamed
> IntlRuleBasedBreakIterator too?... I find it very hard to believe that
> "BreakIterator" is "a very common name", but I'm open to evidence that
> points otherwise. This argument could maybe be made for
> 'Transliterator', which was added in 5.4.
>
In my personal opinion, all Intl classes should be prefixed with Intl. 
It's not so much that BreakIterator is a very common name, but rather a 
very ambiguous name that may point to many different things. Just by the 
fact that multiple people have already posted here that at first they 
thought BreakIterator had something to do with the break statement gives 
you a rather solid hint that the function of this class is not 
immediately clear. Prefixing it with Intl immediately makes it clear 
that it belongs to the Intl superfamily, and limits the potential 
misunderstandings a lot. I actually still don't understand why not all 
Intl classes are prefixed? Isn't that the usual procedure? eg. for 
MySQLi, and pretty much all other extensions?

- Tul