Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sektioneins.de from 85.214.103.31 cause and error)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Mon, 21 May 2012 12:41:24 +0200
Message-ID: <5262BA67-53D2-4D19-9AD6-B1BFDABAC32E@sektioneins.de>
To: Mailing-List php <internals@lists.php.net>
Mime-Version: 1.0 (Apple Message framework v1257)
Subject: zend_execute_internal hook missing from PHP 5
From: stefan.esser@sektioneins.de (Stefan Esser)

Hi,

it recently came to my attention that the function whitelist and =
blacklist feature inside Suhosin is easily bypassable since PHP 5.0.

The reason for this is that PHP is no longer calling the =
zend_execute_internal() hook if a function is called from another =
function (via zend_call_function)

In the days of PHP 4 the code looked like this:

		if (!zend_execute_internal) {
			((zend_internal_function *) =
EX(function_state).function)->handler(EX(opline)->extended_value, =
EX(Ts)[EX(opline)->result.u.var].var.ptr, EX(object).ptr, 1 TSRMLS_CC);
		} else {
			zend_execute_internal(&execute_data, 1 =
TSRMLS_CC);
		}

Nowadays (since PHP 5.0) the code was moved from call_user_function_ex =
to zend_call_function and just looks like this:

		((zend_internal_function *) =
EX(function_state).function)->handler(fci->param_count, =
*fci->retval_ptr_ptr, fci->retval_ptr_ptr, fci->object_ptr, 1 =
TSRMLS_CC);


While this has no immediate impact for average PHP users, it basically =
kills the possibility for an extension like Suhosin to catch all =
function starts.
This should also be a problem for your DTRACE support. And IIRC Xdebug =
was hooking this point (at least in the past), too.

My suggestion is to change the code to call the hook again.

Regards,
Stefan=