Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60611
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Jorrit Schippers - nCode <jschippers@php.net>
Cc: internals@lists.php.net
In-Reply-To: <BB.E5.01728.4B726BF4@pb1.pair.com>
References: <BB.E5.01728.4B726BF4@pb1.pair.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 18 May 2012 17:54:21 +0200
Message-ID: <1337356461.1699.24.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Old bug 40459: Stat and Dir stream wrapper methods
 do not call constructor
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Fri, 2012-05-18 at 12:42 +0200, Jorrit Schippers - nCode wrote:
> So my question is: can anyone familiar with the Stream Wrapper code take
> a look at this issue? My C is not of sufficient level to fix this
> myself. My idea would be to abstract creating a stream wrapper instance
> and invoking the constructor to a separate function and calling that
> function from the various functions that use stream wrappers, as the
> amount of code needed to construct an instance and call the constructor
> seems quite high to copy everywhere.

"Fixing" this is quite trivial.. except  that it breaks any code
depending on the current behavior where people are using the constructor
in a way which might have an bad impact. This could only be done in
master.

Sometime ago I stumbled over that behavior it and had an additional
issue preventing me from fixing it, which I don't remember right now ...

johannes