Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60511
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <4FA7C229.9080901@gmail.com>
References: <CAPmfwEnMypV6DFRnRsnCvj+KQk1JG54TX3r1DNHQO3QQ0f+hjA@mail.gmail.com>
	<CAEZPtU4B0HpVrD4nzN6Cm+ogpza=qeyyfA1qSoRiyFF-dh6iFQ@mail.gmail.com>
	<CAORXhGLkKPY=GpfESDqiCVUhG4vZG7PmqK-v7780fGmvnQyeNw@mail.gmail.com>
	<4F847B8A.9010007@sugarcrm.com>
	<733bc8ea59cf6737563a62886e92fcb6.squirrel@www.l-i-e.com>
	<CAHMUw2Ft49f32di4nyOVWhzi-6Qn7u6yP4La2x_Wn2tZK-CHPA@mail.gmail.com>
	<4FA7C229.9080901@gmail.com>
Date: Tue, 8 May 2012 02:07:49 +0800
Message-ID: <CAHMUw2FA=vevgUBYkNXtmvuvZfSyC4MSA85J53ME=KvY0vWxkQ@mail.gmail.com>
To: Hartmut Holzgraefe <hartmut.holzgraefe@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [off] PHP: a fractal of bad design
From: datibbaw@php.net (Tjerk Anne Meesters)

> On 05/07/2012 05:32 AM, Tjerk Anne Meesters wrote:
>
>> Validated or not, why would type juggling even come into the picture
>> if both variables are of the same type?
>
> For the simple reason that web forms return all input as strings, even
> if the input is actually meant to be numeric
>
> Many PHP database backend functions also return all result fields
> as strings regardless of the actual result type, e.g. mysql_fetch_*(),
> mysqli_fetch_*() and pg_fetch_*() =A0(although that's more debatable)

Granted, I realized that my comment came across a bit too generic.
What I meant to say is that the type juggling should be applied within
its realm of usefulness and skipped otherwise lest it tell me "they're
both pretty big numbers" :)

I've always felt overly pedantic when I used =3D=3D=3D or strcmp() in strin=
g
comparisons (assuming the equality edge cases were not an issue; e.g.
same string composition).

>
> So if both operands look numeric (even though they are actually of
> type string) type juggling kicks, and in your MD5 example it
> unfortunately kicks in with a conversion to float for both sides
> and you're running into the "never compare floats for equality"
> trap ... (which is being worked on for the string comparison case
> though, i just don't have the bug number at hand right now)

I'm assuming that you're referring to this bug reference:
https://bugs.php.net/bug.php?id=3D54547

The proposed patch therein looks okay, though I'm not sure why the
added test case is for 64bit systems only; seems to me that it can /
should be run for other systems too.