Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60414 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65565 invoked from network); 2 May 2012 08:46:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 May 2012 08:46:43 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.215.42 mail-lpp01m010-f42.google.com Received: from [209.85.215.42] ([209.85.215.42:47773] helo=mail-lpp01m010-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 69/F3-38165-174F0AF4 for ; Wed, 02 May 2012 04:46:42 -0400 Received: by lahl5 with SMTP id l5so262184lah.29 for ; Wed, 02 May 2012 01:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=6NU7eupCS1UwQtu+kf90fdSG+1XKto4LKT9ituesGco=; b=xeq/1pUzJTOCe0dEuaEozGd2P8oRDIHzO1N/Gkw0QkdnOC2cYJ15yqD16sf98LNtFE 5ByBFNRWOhSwzqex1v2AV0gUj0igImmlGLTLsakQxqCoIbZoVykuw6yz3Hzj5OlpYShk L3zeFmzFm8jZH5xyUPqgrFQffe0A48bX96uJmDuSiFYSa3S7Ji7sAlD786+onnFdQ3VO HCwwZbr7DAciNMnDmVDdNlVFpTCwoaU8qZv7SqHz/+++O6vpYuUU0s52Hc1dqKhx+4m2 QFkamZjU9Fys2S8qML874/WUm6Bzf/L7rzaegr9z/tUTsWOI7MlBATkiuYu8EOskRBRb 6MuQ== Received: by 10.112.51.225 with SMTP id n1mr3424995lbo.27.1335948397761; Wed, 02 May 2012 01:46:37 -0700 (PDT) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.112.20.73 with HTTP; Wed, 2 May 2012 01:46:11 -0700 (PDT) In-Reply-To: References: Date: Wed, 2 May 2012 16:46:11 +0800 X-Google-Sender-Auth: 71fTJh_aC4IlMgS7TnrwsHJ9HPM Message-ID: To: Patrick ALLAERT Cc: Nikita Popov , PHP internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] Allow non-variable arguments to empty() and isset() From: laruence@php.net (Laruence) On Mon, Apr 30, 2012 at 3:50 PM, Patrick ALLAERT w= rote: > Hi, > > 2012/4/12 Nikita Popov : >> PS: I added isset() too, to address the consistency concerns mentioned o= n IRC. > > I would have voted +1 if it didn't contain the isset() change. None of > the examples used in the isset_with_expr.phpt test seems logic to me. Hi: isset and empty are generally think as a pair, and the both even share one ZEND_OP: ZEND_ISSET_ISEMPTY_VAR so I think if you want to change empty, you should also change isset. thanks > > Care to explain the consistency concerns here? > > Patrick > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > --=20 Laruence =C2=A0Xinchen Hui http://www.laruence.com/