Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6040 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70173 invoked by uid 1010); 3 Dec 2003 01:02:53 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 70138 invoked from network); 3 Dec 2003 01:02:53 -0000 Received: from unknown (HELO stella.fastforwardnetwork.com) (209.51.153.50) by pb1.pair.com with SMTP; 3 Dec 2003 01:02:53 -0000 Received: (qmail 13057 invoked from network); 3 Dec 2003 02:05:21 -0000 Received: from p508ab217.dip.t-dialin.net (HELO hristov.com) (80.138.178.23) by d.goto.bg with SMTP; 3 Dec 2003 02:05:21 -0000 Message-ID: <3FCD3600.3030700@hristov.com> Date: Wed, 03 Dec 2003 02:01:52 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.6b) Gecko/20031202 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sara Golemon , internals@lists.php.net References: <3FCD2E06.6090809@hristov.com> <20031203005632.61115.qmail@pb1.pair.com> In-Reply-To: <20031203005632.61115.qmail@pb1.pair.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: BC broken for strrpos()/strripos() From: php@hristov.com (Andrey Hristov) Sara Golemon wrote: >>The documenation of both function states if the second parameter is an >>integer instead of string then its value is used as a ord of the character >>to be used during the search. This no more true with HEAD. >> >> >> >Good catch. This should not have been broken, I'll fix this. > > okie >>What do you think? Is it ok to break the BC here or not? As you see the >>other change introduced with the patch is to use the whole needle string >>while searching, not only the first character. >> >> >> >That break was intentional. Having strrpos() behave differently from >strpos() in regards to needle size was not a good thing. > > In this case it should be stated somewhere maybe in the still imaginery "the_thin_differences_between_PHP4_and_PHP5.txt" >-Sara > > > Andrey