Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60399
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <CAH-PCH4vqVxtJbyrSThH0LSqND0+g1NgwJAw+m=-WwmgAAO3jw@mail.gmail.com>
References: <CAF+90c_N7fhQG_62pEgw_qm2LTDJf=ie0tN1PQVq4XNpMEYcmQ@mail.gmail.com>
	<CACwt+Jdn7hS8mszbEhhFtthL7hisG-SaXDahzKb9MhY2ZjOWLA@mail.gmail.com>
	<CAF+90c9nqRwiFETJk_2f_hEyncdVkb84m9_RGRXgvAvxqupVTw@mail.gmail.com>
	<CAH-PCH4vqVxtJbyrSThH0LSqND0+g1NgwJAw+m=-WwmgAAO3jw@mail.gmail.com>
Date: Tue, 1 May 2012 18:52:09 +0200
Message-ID: <CACQesk44g9iT98gcMEzwwkx3MuCvmqv7XdT1pLE-c1Y3rDd-TQ@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Nikita Popov <nikita.ppv@googlemail.com>, Patrick ALLAERT <patrickallaert@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Allow non-variable arguments to empty() and isset()
From: colder@php.net (Etienne Kneuss)

Hi,

On Tue, May 1, 2012 at 18:43, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>
> albeit I'm not laruence, but I also supported the idea to keep consistency
> across the allowed params of empty and isset.
> here is my reasoning:
> - both isset and empty are language constructs, which many people use
> almost interchangeability, changing one of them in a way that the same
> expression works with one of them, but blows up with a parse error seems
> wrong to me.
> - maybe you think that isset doesn't really make sense with expressions,
> but don't forget that this patch would also allow constants to be used with
> empty/isset, and imo isset(some_constant); would be useful and maybe more
> straightforward for the people new to the language.


So isset(UNDEFINEDCONSTANT) will be isset("UNDEFINEDCONSTANT") which will/should
1) yield a notice, which is unnexpected for isset
2) return true, which is also unexpected.

I don't see much point in that.

Best regards,

-- 
Etienne Kneuss
http://www.colder.ch