Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60387
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpdBFWJOGu3d+kA2YBt6UA==E435n3-hCLM_Q21kup9Zfw@mail.gmail.com>
References: <3B7600EC10A34F89AA8195C7A83089C0@gmail.com> <CABBJUpdBFWJOGu3d+kA2YBt6UA==E435n3-hCLM_Q21kup9Zfw@mail.gmail.com>
Date: Tue, 1 May 2012 21:07:07 +0800
Message-ID: <CAG1chorRcm25od=9NRG29d2fEYHyAnzYU5EQTpGwiC++cv4HrQ@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, tony2001@php.net, danko@very.lv, stas@php.net, 
	dmitry@php.net, nikic@php.net, felipe@php.net
Content-Type: multipart/alternative; boundary=00235452f834a59bf804bef94063
Subject: Re: Bug/Req:#61422&#39003 enble Type Hint autoloading
From: reeze.xia@gmail.com (reeze)

--00235452f834a59bf804bef94063
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi, Laruence:

   I mean pass a wrong class object to a function/method. if the type
hinted Class didn't loaded, we
could try to load it. (if it's the right class, nothing happened), eg.

         function func(NotFoundClass $a) {}

maybe we could pass another class instance.
$a =3D new DemoClass();
func($a);

It would be useful for class_alias like Bug#61422 requested.
It's a little narrow feature usage scenario=EF=BC=8Cbut it gives a way to h=
andle
it. so I think
It might be useful=E3=80=82
 if failed to autoload it raise E_CATCHABLE_FATAL, loaded class will simple
released
 if user catch the E_CATABLE_FATAL, loaded class will be useful, since it
will be used later.
 if loaded success everyone is happy.


On 1 May 2012 20:25, Laruence <laruence@php.net> wrote:

> On Tue, May 1, 2012 at 8:03 PM, reeze <reeze.xia@gmail.com> wrote:
> > Hi internals:
> > danko reported this bug#61422: Lack of autoload on type hinting breaks
> > class_alias=E3=80=82
> > now parmeter type hint DID NOT trying to autoload.  I think allow it
> > autoloading could be helpful.
> >
> > BUGS&Commit for quick refer:
> > - https://bugs.php.net/bug.php?id=3D61422
> > - https://bugs.php.net/bug.php?id=3D39003
> > - http://svn.php.net/viewvc?view=3Drevision&revision=3D220906
> >
> > PROPOSAL(FR)=EF=BC=9A
> > **I'm asking if we can enable type hint autoloading?**
> >
> > I did some homework:
> > - Before FIX for #39003, parameter type hint will try to autoload the
> hint
> > class if not found.
> >           after this fix it will not. in bug#39003: the final result wa=
s
> DOC
> > Problem, seems we all agreed
> >           that it SHOULD autoloading.
> > - But in
> > revision: http://svn.php.net/viewvc?view=3Drevision&revision=3D220906 I=
t was
> > **FIXED**
> >           I try to search RFC about typehint, I didn't find anything
> about
> > it. It was commited really long time ago
> >           almost 6 years ago, it would be very nice if Antony
> Dovgal still
> > remember it;)
> >
> > REASON=EF=BC=9A
> >     Here is my reason to ask whether we can enable it:
> >
> > 1. Autoload will only happened when function/method calling. so does an=
y
> > other autoloading,
> >     I mean it wouldn't hurt performance.
> > 2. Class will be used for sure, so trying to autoload it is reasonable:
> >        - If we need check certain Class, then we have to use the class =
in
> > function/method.
> >        - most of time it already loaded*, so autoloading happened rarel=
y.
> > 3. If pass the wrong type and the hinted class not found  this gives
> > autoloader a change to handle it
> >     like the #61422's test script did. we can do something if not found=
.
> > since we use the class in
> >     function/method, autoload the class is reasonable. most of the time
> we
> > would not use the *FEATURE*,
> >     but it could make it more flexible.
> >
> > PATCH:
> >
> > 1. change zend_verify_arg_class_kind to autoload class
> > 2. if class can't load, zend_fetch_class silently return (No fatal here=
)
> to
> > give zend_verify_arg_class_kind a chance
> >     to report previous catchable_fatal_error eg=EF=BC=9A
> > Catchable fatal error: Argument 1 passed to func() must be an instance =
of
> > AX, integer given=E3=80=82
> >
> > a simple patch attached request for comment.
> >
> > Finally, What do you guys think about it?
> Hi:
>    thanks for writing this,  but I was a little confused,  please
> correct me if I mis-understand you.
>
>    if you pass a right instance of class to a function , how can that
> class not be loaded already?
>
>    for example:
>    function foo(Foo_Bar $a) {
>    }
>
>    how can you pass a Foo_Bar instance to function foo without
> Foo_Bar class already defined?
>
>
> thanks
>
>
> >
> > Thanks.
> > Best,
> > --
> > reeze | simpie.com
>
>
>
> --
> Laruence  Xinchen Hui
> http://www.laruence.com/
>



--=20
http://reeze.cn

--00235452f834a59bf804bef94063--