Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6038
Return-Path: <pollita@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 61141 invoked by uid 1010); 3 Dec 2003 00:56:33 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 61116 invoked by uid 1007); 3 Dec 2003 00:56:32 -0000
Message-ID: <20031203005632.61115.qmail@pb1.pair.com>
To: internals@lists.php.net
References: <3FCD2E06.6090809@hristov.com>
Date: Tue, 2 Dec 2003 16:56:32 -0800
Lines: 20
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
X-Posted-By: 169.229.139.92
Subject: Re: BC broken for strrpos()/strripos()
From: pollita@php.net ("Sara Golemon")

> this night i saw that the BC of strrpos()/strripos()
> is broken by a patch commited by pollita 7 months ago :
>
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?login=2&r1=1.370&r2=1.371&ty=u
> The documenation of both function states if the second parameter is an
> integer instead of string then its value is used as a ord of the character
> to be used during the search. This no more true with HEAD.
>
Good catch.  This should not have been broken, I'll fix this.

> What do you think? Is it ok to break the BC here or not? As you see the
> other change introduced with the patch is to use the whole needle string
> while searching, not only the first character.
>
That break was intentional.  Having strrpos() behave differently from
strpos() in regards to needle size was not a good thing.

-Sara