Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60305 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88886 invoked from network); 25 Apr 2012 00:29:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Apr 2012 00:29:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=philip@roshambo.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=philip@roshambo.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain roshambo.org from 209.85.160.42 cause and error) X-PHP-List-Original-Sender: philip@roshambo.org X-Host-Fingerprint: 209.85.160.42 mail-pb0-f42.google.com Received: from [209.85.160.42] ([209.85.160.42:54687] helo=mail-pb0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 40/D5-54790-D55479F4 for ; Tue, 24 Apr 2012 20:29:17 -0400 Received: by pbbrp2 with SMTP id rp2so773760pbb.29 for ; Tue, 24 Apr 2012 17:29:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=OXBEmozemZxdBW8/xRsFbbeCPdsJyxZPqekJrMT2FB4=; b=A/fMgF4uC4S3RuK1GKayhlkrH27dWHaaEud84T76WJ3ooNCGAmtVZjWwhI4lfiC+9P Cy0Zn0rwnjozuecBS8B58BHDpmxinMROLMeWi/17l5RumKTLBAv3nNZpxrW3x24ZghfI Y7aEIQ0WG5fPq/A+Om0pDcc+Ens1/xAmj0VCkmoIXOKXx9b6R82u7g/pZUY8T4XQleG9 jQIGSpGJ7ZlKVg868Jqb3ucJD1d3xm8N62zxSNG3FQ/+5cfMAzkhRTjFDlkan3r8Ki3U kmQnCzP98CmrWl+6YZM9Bso8gCBz2jCwghvjX7Xj8DmNzaDk5d3JDDPG2UIoXeKBQ0Bu kHZw== Received: by 10.68.129.129 with SMTP id nw1mr2548484pbb.29.1335313754305; Tue, 24 Apr 2012 17:29:14 -0700 (PDT) Received: from [192.168.2.100] (c-71-56-134-232.hsd1.wa.comcast.net. [71.56.134.232]) by mx.google.com with ESMTPS id na8sm17403409pbc.7.2012.04.24.17.29.12 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Apr 2012 17:29:13 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=windows-1252 In-Reply-To: <4F973B5C.7060901@sugarcrm.com> Date: Tue, 24 Apr 2012 17:29:11 -0700 Cc: PHP Internals Content-Transfer-Encoding: quoted-printable Message-ID: References: <4F96D81E.5090007@sugarcrm.com> <0547FCEA-5112-404C-8426-C74E667ED1A1@roshambo.org> <4F973B5C.7060901@sugarcrm.com> To: Stas Malyshev X-Mailer: Apple Mail (2.1257) X-Gm-Message-State: ALoCoQmj6rxAnpKT+3wD9+/CEKqfzR78AYiIWlvj55B2vjCikIKs5USkoqnYndRpc2zXoQYOpHQi Subject: Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0 From: philip@roshambo.org (Philip Olson) On Apr 24, 2012, at 4:46 PM, Stas Malyshev wrote: > Hi! >=20 >> The less people beginning to rely on this bug the better, and this is >> a critical time. The impact of this BC break feels larger considering=20= >> MQ is enabled by default in PHP 5.3 and below. >=20 > I understand but a) nobody should be using magic quotes anyway and b) > holding release for 5.4.1 because of a very minor issue with easy > workaround doesn't seem productive for me. If we hold release for each > such thing, we'll never have 5.4.1 at all. I don\'t understand why get_magic_quotes_gpc() and = get_magic_quotes_runtime() get such a bad wrap. People using these functions are not using magic quotes, but instead they (most) are writing code that will work in = environments that have it enabled. This helps code work in PHP 5.4 and below, as = opposed=20 to only PHP 5.4 and above. And yes, the number of people that use \"=3D=3D=3D false\" here is small = I reckon. But this is a BC break in a BC function. Something feels very wrong = about=20 that. So I understand that we cannot hold a release for every bug and that we=20= have known bugs in every release, but will we revert this change after = it exists in two PHP releases? Whatever the case, this also means we\'ll = have=20 to document this change=85 and here I was trying to be lazy. :) Regards, Philip