Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:60303 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 84377 invoked from network); 24 Apr 2012 23:46:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Apr 2012 23:46:42 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.203 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.203 smtp203.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.203] ([67.192.241.203:51998] helo=smtp203.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4E/15-54790-06B379F4 for ; Tue, 24 Apr 2012 19:46:41 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp10.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 911F71B8147; Tue, 24 Apr 2012 19:46:37 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp10.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 536CB1B810B; Tue, 24 Apr 2012 19:46:37 -0400 (EDT) Message-ID: <4F973B5C.7060901@sugarcrm.com> Date: Tue, 24 Apr 2012 16:46:36 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Philip Olson CC: PHP Internals References: <4F96D81E.5090007@sugarcrm.com> <0547FCEA-5112-404C-8426-C74E667ED1A1@roshambo.org> In-Reply-To: <0547FCEA-5112-404C-8426-C74E667ED1A1@roshambo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > The less people beginning to rely on this bug the better, and this is > a critical time. The impact of this BC break feels larger considering > MQ is enabled by default in PHP 5.3 and below. I understand but a) nobody should be using magic quotes anyway and b) holding release for 5.4.1 because of a very minor issue with easy workaround doesn't seem productive for me. If we hold release for each such thing, we'll never have 5.4.1 at all. > This change shouldn't damage the RC QA process as all this does (tm) > is change the return of false to 0. And considering that the magic > quotes feature is removed, this change should not affect other code. Code change means we can't release. I'm not comfortable putting untested code in the release. We'll get it in 5.4.2. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227