Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60298
Return-Path: <philip@roshambo.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 74540 invoked from network); 24 Apr 2012 22:26:07 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Apr 2012 22:26:07 -0000
Authentication-Results: pb1.pair.com header.from=philip@roshambo.org; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=philip@roshambo.org; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain roshambo.org from 209.85.210.45 cause and error)
X-PHP-List-Original-Sender: philip@roshambo.org
X-Host-Fingerprint: 209.85.210.45 mail-pz0-f45.google.com  
Received: from [209.85.210.45] ([209.85.210.45:43552] helo=mail-pz0-f45.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 83/63-54790-D78279F4 for <internals@lists.php.net>; Tue, 24 Apr 2012 18:26:07 -0400
Received: by dacx6 with SMTP id x6so1615994dac.18
        for <internals@lists.php.net>; Tue, 24 Apr 2012 15:26:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=subject:mime-version:content-type:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to:x-mailer
         :x-gm-message-state;
        bh=HMIlSBWpym1V4recu8vcvTvZerxHDmjjp4e/TsFSmoE=;
        b=kR3DG1vW1L170TMA6Jj6mXTJxe/yM1u2mo/PVpwS6mIce6BlZiFvCBvP//LKOleZzY
         YIOj9TRwMfhgDQZL2btVDvrYqQ2E7hlJ5vWT6AN1H0YLh9fekO3b9RHndJSYOw4a8don
         n5LWZpXB9fFv/+KAZiXffTsh44hJNnGXbVzmnNLY8YViUvDYq0ToBFi8pOuv6You/P4E
         N631nN1hb+3HBri/o70mXSiYIuzzQsGMm36M4aXha3dOSfuX3V4MwzYJRu6vQKk/BZoM
         r34Ab2CobtF2k6U2OGJLmVXCgoNpPmWI1RIkUE1p1/K+r1MIq94PQ1JIe3P84WevAW1D
         11EA==
Received: by 10.68.221.133 with SMTP id qe5mr1816462pbc.24.1335306362715;
        Tue, 24 Apr 2012 15:26:02 -0700 (PDT)
Received: from [192.168.2.100] (c-71-56-134-232.hsd1.wa.comcast.net. [71.56.134.232])
        by mx.google.com with ESMTPS id gn2sm8025742pbc.17.2012.04.24.15.26.00
        (version=TLSv1/SSLv3 cipher=OTHER);
        Tue, 24 Apr 2012 15:26:01 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <4F96D81E.5090007@sugarcrm.com>
Date: Tue, 24 Apr 2012 15:25:59 -0700
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Message-ID: <0547FCEA-5112-404C-8426-C74E667ED1A1@roshambo.org>
References: <EA212731-C998-4623-BDC8-7D16663DAB1E@roshambo.org> <4F96D81E.5090007@sugarcrm.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
X-Mailer: Apple Mail (2.1257)
X-Gm-Message-State: ALoCoQlunVCZ8AUFdY4IfOEV+OhvzJCqtEnzTMkDQ/yUjR0Nc6hx8c8bF27br2fCyrv1lAyUKoZ8
Subject: Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0
From: philip@roshambo.org (Philip Olson)


On Apr 24, 2012, at 9:43 AM, Stas Malyshev wrote:

> Hi!
> 
>>  https://bugs.php.net/61784
>> 
>> The get_magic_quotes_gpc() function returns 0/1 before 5.4, but now 
>> it returns boolean false. Instead it should return 0. Fixing this 
>> feels like a bug fix, which would go in 5.4.1. Thoughts?
> 
> I do not see a reason to hold 5.4.1 for this.

The less people beginning to rely on this bug the better, and this is
a critical time. The impact of this BC break feels larger considering 
MQ is enabled by default in PHP 5.3 and below.

This change shouldn't damage the RC QA process as all this does (tm) 
is change the return of false to 0. And considering that the magic 
quotes feature is removed, this change should not affect other code.

Oh, sometimes it's nice that more people use == versus ===. ;)

Regards,
Philip