Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60295
Return-Path: <keisial@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 68609 invoked from network); 24 Apr 2012 21:51:21 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Apr 2012 21:51:21 -0000
Authentication-Results: pb1.pair.com header.from=keisial@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=keisial@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.170 as permitted sender)
X-PHP-List-Original-Sender: keisial@gmail.com
X-Host-Fingerprint: 209.85.212.170 mail-wi0-f170.google.com  
Received: from [209.85.212.170] ([209.85.212.170:59400] helo=mail-wi0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id FC/42-54790-850279F4 for <internals@lists.php.net>; Tue, 24 Apr 2012 17:51:20 -0400
Received: by wibhr17 with SMTP id hr17so4047023wib.5
        for <internals@lists.php.net>; Tue, 24 Apr 2012 14:51:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=UetLUeiZFozLiVPNAaElUh5gvy2T58UN5PJGdRj3iMc=;
        b=fEpzA3FNh0eXpm7HdDeqcBhYt5xlWLPSR1jHM9rtBoyK/BFF9gVd3488OxGZ8/f5fF
         iviwFQU/OCVzlTWBvOx/bMdXe8AebppjraA1aM/CEaSGo5euKnOU2+PEEIpd4MG01Y7C
         mOJkj4X/GBHkBwvKy99RvEgdLhpPQ6WEq8QUXU+zw5vUFnx3R89ey4htC0rMm+VFqir2
         BSY0CUKZn83xkLmA/duAQY97o960FpocOeH5XWbXMcOqXjQeiU7Z/E42pezq4ZaCrsKA
         7V8M2honZARMD61PYbOZeUI0REyHn2QU8JcjPUoMANHtjU3P31/dEggqC4r/FAmmafNk
         5Qxw==
Received: by 10.216.134.28 with SMTP id r28mr121914wei.2.1335304277802;
        Tue, 24 Apr 2012 14:51:17 -0700 (PDT)
Received: from [192.168.1.26] (31.Red-88-13-201.dynamicIP.rima-tde.net. [88.13.201.31])
        by mx.google.com with ESMTPS id fl2sm51048239wib.2.2012.04.24.14.51.14
        (version=SSLv3 cipher=OTHER);
        Tue, 24 Apr 2012 14:51:15 -0700 (PDT)
Message-ID: <4F97204B.3040007@gmail.com>
Date: Tue, 24 Apr 2012 23:51:07 +0200
User-Agent: Thunderbird
MIME-Version: 1.0
To: Paul Dragoonis <dragoonis@gmail.com>
CC: Philip Olson <philip@roshambo.org>, 
 PHP Internals <internals@lists.php.net>
References: <EA212731-C998-4623-BDC8-7D16663DAB1E@roshambo.org> <CAKxcST-HwtubwUTynwokUbGr9ScVKxOtNyrntZ5XOdLzFY1-KQ@mail.gmail.com>
In-Reply-To: <CAKxcST-HwtubwUTynwokUbGr9ScVKxOtNyrntZ5XOdLzFY1-KQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0
From: keisial@gmail.com (=?ISO-8859-1?Q?=C1ngel_Gonz=E1lez?=)

On 24/04/12 18:11, Paul Dragoonis wrote:
> Happy to patch this once someone confirms this is a bug and not
> "changed behaviour" in 5.4.
>
> - Paul.
Why would such behavior change be desired?
get_magic_quotes_gpc() is kept only for compatibility with scripts which
did magic quote detection.

As such, it should return its 'traditional' value.

get_magic_quotes_gpc() got wrongly deprecated in 5.4, then restored...
I think that when implementing it to always return that there are no
magic_quotes,
it was just inadvertedly changed to false. Which is the "logical" thing
as those 0/1 work as
booleans, but that should have been done long ago, when designing it,
not now.

Regards