Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60153
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F8DF4B1.2040307@sugarcrm.com>
References: <4F8DF4B1.2040307@sugarcrm.com>
Date: Wed, 18 Apr 2012 10:56:28 +0500
Message-ID: <CAAAa2sjJax_pFRTacdVmZsAs7BkBF8yhCpGmw7xmgXHT+kMBvQ@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] skipping optional parameters
From: confik@gmail.com (Alexey Shein)

Hi!

My opinion is that solution tries to overcome bad consequences of
legacy code, when it's not feasible to change something without
breakage a lot of code, although the real solution is to refactor
functions with long variable lists (as Uncle Bob says), maybe this
should be noted in documentation of this feature.

Alan nicely highlighted all cons of this feature, but instead of
voting against it I suggest to put that into the docs, so people can
use it wisely and understand consequences.

One question about implementation:
Given we have this function
>   function create_query($where, $order_by, $join_type='', $execute = false, $report_errors = true) {}
and this statement
> On the engine level, it will be implemented by putting NULL in the place where the parameter is passed.

what value $join_type will get on this call?
create_query("deleted=0", "name",,, /*report_errors*/ true);

NULL or empty string? I.e. will optional parameters always get NULLs
or their default values?
Thanks.
-- 
Regards,
Shein Alexey