Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:60103
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+Ky_uOofeE=A4S5JqZGTqYgaHy57LNoj3zJs1qcX1L5+SeoBQ@mail.gmail.com>
References: <4F89D4F1.8070009@ralphschindler.com> <CA+Ky_uOofeE=A4S5JqZGTqYgaHy57LNoj3zJs1qcX1L5+SeoBQ@mail.gmail.com>
Date: Tue, 17 Apr 2012 12:36:43 -0700
Message-ID: <CA+Ky_uOCVM1ALdTFJRVmFMwRbBzCJwj--_zxoCx2sq7y7vaAeg@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=14dae9340fbf5f59fd04bde5119a
Subject: Re: [PHP-DEV] New Feature: Fully qualified class name resolution as
 scalar with class keyword
From: ww.galen@gmail.com (Galen Wright-Watson)

--14dae9340fbf5f59fd04bde5119a
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Apr 14, 2012 at 12:50 PM, Ralph Schindler
<ralph@ralphschindler.com>wrote:

> Hi all,
>
> There are many different use cases were in code we expect classes names as
> arguments to functions as fully qualified names.  We do this in ZF a lot
> with our Service Location and DI components, but also with our code
> reflection API, etc.  A more interesting use case I would like to call out
> is with PHPUnit, for example in a test, you might find this:
>
>  $mock = $this->getMock('A\Namespaced\**ClassName');
>
> [...]
>
>
> This overloads the "class" keyword, and by virtue of the existing usage of
> "class" this feature is completely backwards compatible.  All existing
> tests pass.  For example, the above PHPUnit snipped would become:
>
> Would it be easy to have a patch that simply allows use of the class name,
or is the "::class" suffix necessary to resolve some ambiguity? Example
usage:

    $mock = $this->getMock(A\Namespaced\**ClassName);
    # or
    use A\Namespaced\ClassName;
    $mock = $this->getMock(ClassName);

Would changing the definition for class_name_scalar be sufficient?

    class_name_scalar:
        class_name { zend_resolve_class_name(&$1, ZEND_FETCH_CLASS_GLOBAL,
1 TSRMLS_CC); $$ = $1;  }
    ;

To my eye, this is the least surprising syntax.

--14dae9340fbf5f59fd04bde5119a--