Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59973
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F89D4F1.8070009@ralphschindler.com>
References: <4F89D4F1.8070009@ralphschindler.com>
Date: Mon, 16 Apr 2012 01:13:23 +0200
Message-ID: <CAJWj5+EhPkmpWmAz4Yekh794SO4x4sM27VZLk-X9qsDzMP4aNg@mail.gmail.com>
To: Ralph Schindler <ralph@ralphschindler.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] New Feature: Fully qualified class name resolution as
 scalar with class keyword
From: simonsimcity@googlemail.com (Simon Schick)

2012/4/14 Ralph Schindler <ralph@ralphschindler.com>:
> Hi all,
>
> There are many different use cases were in code we expect classes names a=
s
> arguments to functions as fully qualified names. =C2=A0We do this in ZF a=
 lot
> with our Service Location and DI components, but also with our code
> reflection API, etc. =C2=A0A more interesting use case I would like to ca=
ll out
> is with PHPUnit, for example in a test, you might find this:
>
> =C2=A0$mock =3D $this->getMock('A\Namespaced\ClassName');
>
> This becomes cumbersome when you are dealing with lots of strings about l=
ots
> of class names. =C2=A0This is also an area where, currently, namespace
> declaration and use statements offer no real support.
>
> The patch located here:
>
> https://github.com/ralphschindler/php-src/commit/02210d51851a96d723fbedcf=
c64cde9f9ae2b22a
>
> ... implements the ability for a developer to leverage the file's namespa=
ce
> declaration and use statements to be able to produce a scalar (string) of
> the class name that can be then used, for example, as an argument to a
> function elsewhere.
>
> This overloads the "class" keyword, and by virtue of the existing usage o=
f
> "class" this feature is completely backwards compatible. =C2=A0All existi=
ng tests
> pass. =C2=A0For example, the above PHPUnit snipped would become:
>
> =C2=A0use A\Namespaced\ClassName;
> =C2=A0$mock =3D $this->getMock(ClassName::class);
>
> Another example with reflection:
>
> =C2=A0use SomeOther\FullyNamespaced\ClassElsewhere as CE;
> =C2=A0$r =3D new ReflectionClass(CE::class);
>
> More examples from the test file:
>
> =C2=A0namespace Foo\Bar {
> =C2=A0 =C2=A0class Baz {}
> =C2=A0 =C2=A0var_dump(Moo::CLASS); // "Foo\Bar\Moo"
> =C2=A0}
>
> =C2=A0namespace {
> =C2=A0 =C2=A0use Bee\Bop as Moo,
> =C2=A0 =C2=A0 =C2=A0 =C2=A0Foo\Bar\Baz;
>
> =C2=A0 =C2=A0var_dump(Baz::class); // "Foo\Bar\Baz"
> =C2=A0 =C2=A0var_dump(Boo::class); // "Boo"
> =C2=A0 =C2=A0var_dump(Moo::CLASS); // "Bee\Bop"
> =C2=A0 =C2=A0var_dump(\Moo::Class); // "Moo"
>
> =C2=A0 =C2=A0$class =3D Baz::class; // assign class as scalar to var
> =C2=A0 =C2=A0$x =3D new $class;
> =C2=A0 =C2=A0var_dump($x); =C2=A0object(Foo\Bar\Baz)#1 (0) {}
> =C2=A0}
>
>
> What do you guys think?
>
> -ralph
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Hi, Ralph

I really like this feature in general.

One thing I personally dislike in this implementation is the
difference between CLASS and class ... One with and one without
namespaces ...
If we can unify that, this would be a great help in understanding that
feature in future and getting the difference while reading code.
And please don't forget: Code will be written once, maybe rewritten
some times, but it will be read way more times!

Bye
Simon