Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59874
Return-Path: <nikita.ppv@googlemail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 64527 invoked from network); 13 Apr 2012 12:12:24 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 13 Apr 2012 12:12:24 -0000
Authentication-Results: pb1.pair.com header.from=nikita.ppv@googlemail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@googlemail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.217.170 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@googlemail.com
X-Host-Fingerprint: 209.85.217.170 mail-lb0-f170.google.com  
Received: from [209.85.217.170] ([209.85.217.170:64432] helo=mail-lb0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E3/25-35770-628188F4 for <internals@lists.php.net>; Fri, 13 Apr 2012 08:12:23 -0400
Received: by lbbgf7 with SMTP id gf7so2401826lbb.29
        for <internals@lists.php.net>; Fri, 13 Apr 2012 05:12:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=googlemail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=/fj1Qn1QFC9xRU2NTgtAU6KhpsdQEB30Mat0XXO2Vfg=;
        b=IsWVLDOmv7MaDLsT4GDavfqjXD61TKgZmZG3EXVffZtlxaAZtJbt8ijMDhNOxQShcY
         vthd5vlwQ7SV/oIkbZSOWG0vyQnss6Cp1GpxmmPunb6s1FDxrZ9k0eW8TVDDMLB0HiHy
         pRuAr81sIczJqztoejFaQ//4qFQcpawu+v2u8I4qZICekocBNfj75HaZdJvLRd0CsfB0
         po71/axfBeP8HQQBRVOAt4ez1QSgWLzrZayfoQ2ltqz01RVqc73pICFCov8/K344cUbp
         FoaJU4z2J5B3W4zlGGJ+aWD3aLnn2ehZB3c9lmz8XKsOZGzpfvpBn8brUpXwoxhho6KJ
         hKEQ==
MIME-Version: 1.0
Received: by 10.152.131.9 with SMTP id oi9mr1277964lab.6.1334319139277; Fri,
 13 Apr 2012 05:12:19 -0700 (PDT)
Received: by 10.152.127.68 with HTTP; Fri, 13 Apr 2012 05:12:19 -0700 (PDT)
In-Reply-To: <CA+Ky_uMHzxYt_=z1ZgB2xbA9hzgVvKu_n5VFWdiAMMrn6vagsQ@mail.gmail.com>
References: <CAF+90c_N7fhQG_62pEgw_qm2LTDJf=ie0tN1PQVq4XNpMEYcmQ@mail.gmail.com>
	<CA+Ky_uMHzxYt_=z1ZgB2xbA9hzgVvKu_n5VFWdiAMMrn6vagsQ@mail.gmail.com>
Date: Fri, 13 Apr 2012 14:12:19 +0200
Message-ID: <CAF+90c_azm97U_wP=3goYca7=7dxe5+toV6pUQwevwbrbOvBiQ@mail.gmail.com>
To: Galen Wright-Watson <ww.galen@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Allow non-variable arguments to empty() and isset()
From: nikita.ppv@googlemail.com (Nikita Popov)

On Fri, Apr 13, 2012 at 12:42 AM, Galen Wright-Watson
<ww.galen@gmail.com> wrote:
> Just to be clear, under the new behavior, calling "empty" or "isset" on
> undefined variables and undefined array indices shouldn't produce a notice
> when E_NOTICE is set, correct? Basically, the change isn't regressive.
Yup, that's right. So the change is BC-safe :)

> If this is so, how about adding appropriate regression
> tests to empty_with_expr.phpt and empty_with_isset.phpt?
The normal empty()/isset() behavior (including the suppression of the
notice) is tested in a few other tests, that's why I didn't add
additional tests for it there :)

Nikita