Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59805
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_N7fhQG_62pEgw_qm2LTDJf=ie0tN1PQVq4XNpMEYcmQ@mail.gmail.com>
References: <CAF+90c_N7fhQG_62pEgw_qm2LTDJf=ie0tN1PQVq4XNpMEYcmQ@mail.gmail.com>
Date: Thu, 12 Apr 2012 15:42:34 -0700
Message-ID: <CA+Ky_uMHzxYt_=z1ZgB2xbA9hzgVvKu_n5VFWdiAMMrn6vagsQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8f22c681db741704bd8314b2
Subject: Re: [PHP-DEV] [RFC] Allow non-variable arguments to empty() and isset()
From: ww.galen@gmail.com (Galen Wright-Watson)

--e89a8f22c681db741704bd8314b2
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Apr 12, 2012 at 2:42 PM, Nikita Popov <nikita.ppv@googlemail.com>wrote:

>
> As per the comments I created an RFC, proposing to allow arbitrary
> expressions to be passed to empty() and isset():
>
> https://wiki.php.net/rfc/empty_isset_exprs
>
> The patch is available as a PR:
>
> https://github.com/php/php-src/pull/54
>
> Nikita
>
> PS: I added isset() too, to address the consistency concerns mentioned on
> IRC.
>
> Just to be clear, under the new behavior, calling "empty" or "isset" on
undefined variables and undefined array indices shouldn't produce a notice
when E_NOTICE is set, correct? Basically, the change isn't regressive.

    <?php
    error_reporting(E_ALL);
    echo empty($foo) ? "\$foo isn't set\n" : "foo: $foo\n";
    # result: "$foo isn't set", and no "Undefined variable" notice.

From my reading of the patch this is true, but I want to make sure I'm not
missing something. If this is so, how about adding appropriate regression
tests to empty_with_expr.phpt and empty_with_isset.phpt?

--e89a8f22c681db741704bd8314b2--