Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59772
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.42 as permitted sender)
References: <CAMU2iguwio_rBgsTaYm4gb-v7BKhgjyabBijKBLQ-EjcKp_rnw@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-A92AC000-976F-44FC-A591-2EEDAC3104C8
In-Reply-To: <CAMU2iguwio_rBgsTaYm4gb-v7BKhgjyabBijKBLQ-EjcKp_rnw@mail.gmail.com>
Message-ID: <0BAF545D-95F6-4C4B-8E03-025E8604B1ED@gmail.com>
Date: Wed, 11 Apr 2012 19:12:09 -0600
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Subject: Re: Push Request #21
From: jason.gerfen@gmail.com ("jason.gerfen@gmail.com")

--Apple-Mail-A92AC000-976F-44FC-A591-2EEDAC3104C8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

There really doesn't seem to be much interest in this proposed patch. Should=
 I continue development efforts on closing this feature request?

I do also have a few questions regarding standards adherence, and memory lea=
k methods of detection.

I ask about the memory leak detection as passing test scripts through valgri=
nd only led me to find leaks in the openssl_pkey_new() function.

Thanks for any help you can provide

Jas

On Apr 3, 2012, at 4:47 AM, Jason Gerfen <jason.gerfen@gmail.com> wrote:

> Please bear with me as I am going to address a few things that (being new)=
 I seem to have over looked upon my initial pull request @ https://github.co=
m/php/php-src/pull/21.
>=20
> I have forked and submitted a push request to add native spkac functionali=
ty per a feature request @ https://bugs.php.net/bug.php?id=3D38917.
>=20
> It introduces five new functions:
> openssl_spki_new()
> openssl_spki_export()
> openssl_spki_export_challenge()
> openssl_spki_verify()
> openssl_spki_details()
>=20
> First I am not sure I should include the openssl_spki_details() function a=
s it may be overkill and the remainder of the PHP OpenSSL extension does not=
 have anything providing the modulus and other details. I am leaning towards=
 the omitting of this in next pull request.
>=20
> Second. The warning message UC first or all LC has been brought up. The re=
mainder of the warnings messages do not use LC at all and I simply followed t=
his example.
>=20
> Third. The adherence to C89 vs. C99 functions, I could not find references=
 to this in any of the internals docs. I very well could have missed it.
>=20
> Fourth. A couple of you made mention of re-factoring to omit goto statemen=
ts. Does this mean the remainder of the ext/openssl/openssl.c file should be=
 re-factored as I originally used this as an example of creating new functio=
ns which does include a few functions making use of goto statements.
>=20
> Thanks for any feedback you can provide
>=20
> --=20
> Jas

--Apple-Mail-A92AC000-976F-44FC-A591-2EEDAC3104C8--