Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59714
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F851805.9040205@sugarcrm.com>
References: <062d97234afa5d35f307cde3f3551a9d.squirrel@webmail.klapt.com>
	<7e6770a85f1256bf34b23ca78045831c.squirrel@webmail.klapt.com>
	<4F847D64.2070500@sugarcrm.com>
	<CAEZPtU4=BvDnErU9y6WJjxoOo0bJ-UzGCmnmN5QKV218vcc_RA@mail.gmail.com>
	<4F84B312.9000005@sugarcrm.com>
	<CAEZPtU7j4HBzS=aOnnB=_z+m1wNqvshbg-2GWYT8bJ2wAsZWAA@mail.gmail.com>
	<4F851805.9040205@sugarcrm.com>
Date: Wed, 11 Apr 2012 07:40:01 +0200
Message-ID: <CAEZPtU7pyOciDFhJrf=+5nkmRE=v1dHyQo-mB0SQsXYnDtcJeA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "ab@php.net" <ab@php.net>, David Soria Parra <dsp@php.net>, 
	=?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Fileinfo fixes for windows
From: pierre.php@gmail.com (Pierre Joye)

Hi!

On Wed, Apr 11, 2012 at 7:35 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> btw, It is not a realy issue as we won't use 5.4.1 tests to test the
>> release but 5.4's branch ones. Too many false positive.
>
> Who are we?

My team and I, as always when we refer to that.

> I'll definitely be using 5.4.1, since that's what I will be
> releasing. There's no point in testing code different from one you're
> releasing. Do you mean windows tests? Are they broken now?

Yes, see the commits, and the LF thing.

>> The lf should not be a problem either as the releases are packaged on
>> linux, so LF is the default there.
>
> I'll merge the .gitattributes patch, since it doesn't hurt anything, but
> not sure about other stuff - still don't understand what's going on
> there and if we need another RC

We do not need another RC for the tests fixes only. It is not optimal
but not critical enough to delay the release any longer. We will
simply use 5.4's branch tests for now as there are far less failures
(related to tests fixes, not code changes).

Also we have to release 5.3.11 final as well (same security fixes) but
we did not hear anything yet from Johannes so far. Johannes?

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org