Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59709
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F84B312.9000005@sugarcrm.com>
References: <062d97234afa5d35f307cde3f3551a9d.squirrel@webmail.klapt.com>
	<7e6770a85f1256bf34b23ca78045831c.squirrel@webmail.klapt.com>
	<4F847D64.2070500@sugarcrm.com>
	<CAEZPtU4=BvDnErU9y6WJjxoOo0bJ-UzGCmnmN5QKV218vcc_RA@mail.gmail.com>
	<4F84B312.9000005@sugarcrm.com>
Date: Wed, 11 Apr 2012 07:25:10 +0200
Message-ID: <CAEZPtU7j4HBzS=aOnnB=_z+m1wNqvshbg-2GWYT8bJ2wAsZWAA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "ab@php.net" <ab@php.net>, David Soria Parra <dsp@php.net>, 
	=?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Fileinfo fixes for windows
From: pierre.php@gmail.com (Pierre Joye)

hi Stas,

On Wed, Apr 11, 2012 at 12:24 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> However, as you won't merge the tests fixes either, we won't 5.4.1's
>> tests at all to valid the build (way too many false positive), it does
>> not really matter anymore.
>
> Wait, are we talking about new test fixes or about tests that are broken
> in RC1 and need fixing? I was assuming it's the former but maybe I miss
> the point entirely. I've run tests of RC1 on Linux and those were just
> fine. If they fail somewhere else please tell me and I'll see if I
> should add those.
> I'm ok with pulling the LF fix, that seems innocent enough - it's not
> even a code change, just a metadata change.

btw, It is not a realy issue as we won't use 5.4.1 tests to test the
release but 5.4's branch ones. Too many false positive.

The lf should not be a problem either as the releases are packaged on
linux, so LF is the default there.

All in all, I do not see a critical stopping preventing us to go final
(and begin with next soonish :) ).

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org