Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59453
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
Sender: yader.hernandez@gmail.com
In-Reply-To: <2489245882729818767@unknownmsgid>
References: <CABaGD72bC8_MLSpP-0WXqtWOXcUGJwfAMj5Z8xPn7YAX83KCxA@mail.gmail.com>
	<1333834026.4220.6.camel@guybrush>
	<CABaGD70ea8i+v=nvdigbGD1Wrd+RGVWqaGq6UcXci26EJ1zbyQ@mail.gmail.com>
	<CABaGD70ffSn4DPDs80d3P8COMPFump5Q3r-iFBE=tPiaF4B8Uw@mail.gmail.com>
	<2489245882729818767@unknownmsgid>
Date: Sat, 7 Apr 2012 23:36:42 -0700
Message-ID: <CABaGD70q_jZH7=E0TuKbfd5GOE3yKuaZbX4KSq9yNPkYhN4Lgw@mail.gmail.com>
To: Xinchen Hui <laruence@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae9399c5dd6fe7e04bd251caa
Subject: Re: [PHP-DEV] how do you create a private property as an array in a class
From: proxilabs@gmail.com (Matthew Hernandez)

--14dae9399c5dd6fe7e04bd251caa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks.

How can I valgrind my extension? Google isn't bringing up many php
extension topics :/

I can't figure out why I keep getting a seg fault:

typedef struct _foo_object {
  zend_object std;
  zval  *elements;
} foo_object;

static foo_object *foo_object_ptr;

PHP_MINIT_FUNCTION(foo_class)
{
  foo_object_ptr =3D emalloc(sizeof(foo_object));

  MAKE_STD_ZVAL(foo_object_ptr->elements);
  array_init(foo_object_ptr->elements);

  return SUCCESS;
}

MAKE_STD_ZVAL(foo_object_ptr->elements);
array_init(foo_object_ptr->elements);

These two lines are causing the seg fault, I'm trying to understand why.

On Sat, Apr 7, 2012 at 8:41 PM, Xinchen Hui <laruence@gmail.com> wrote:

> hi=EF=BC=9A
>  You can refer to ext spl array
>
> Thanks
>
> Sent from my iPhone
>
> =E5=9C=A8 2012-4-8=EF=BC=8C7:12=EF=BC=8CMatthew Hernandez <proxilabs@gmai=
l.com> =E5=86=99=E9=81=93=EF=BC=9A
>
> > Here's what I have so far:
> >
> > typedef struct _foo_class_object {
> > zend_object std;
> > zval  *elements;
> > int size;
> > } foo_class_object;
> >
> > static foo_class_object *foo_class_object_ptr;
> > static zend_class_entry *foo_class_ptr;
> >
> > ZEND_METHOD(foo_class, __construct) {
> > foo_class_object_ptr =3D (foo_class_object
> > *)zend_object_store_get_object(getThis() TSRMLS_CC);
> >
> > array_init(foo_class_object_ptr->elements);
> > }
> >
> > ZEND_METHOD(foo_class, add) {
> > zval *this =3D getThis();
> > zval *item;
> >
> > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &item) =3D=3D
> > FAILURE) {
> >   RETURN_FALSE;
> > }
> >
> > add_next_index_zval(foo_class_object_ptr->elements, item);
> >
> > RETURN_TRUE;
> > }
> >
> > However, this doesn't work. when you call FooClass::add it causes a
> > segfault. I'm sure I'm abusing something :)
> >
> > thx
> >
> > On Sat, Apr 7, 2012 at 2:38 PM, Matthew Hernandez <proxilabs@gmail.com
> >wrote:
> >
> >> Hi Johannes,
> >>
> >> Yes I just found out that I should extend instead of the approach I wa=
s
> >> thinking about.
> >>
> >> So I created this:
> >>
> >> typedef struct _foo_object {
> >> zend_object std;
> >> zval  *array;
> >> int size;
> >> } foo_object;
> >>
> >> So the question is how do I correctly pass foo_object around so that I
> can
> >> manipulate *array ? Having a private variable would mean calling
>  getThis()
> >> and handling it that way would be trivial.
> >>
> >> Are there any examples I could see? I'm using the slides from your
> >> presentation in 2009 to help me.
> >>
> >> thanks
> >>
> >> On Sat, Apr 7, 2012 at 2:27 PM, Johannes Schl=C3=BCter <
> johannes@schlueters.de>wrote:
> >>
> >>> Hi,
> >>>
> >>> On Sat, 2012-04-07 at 11:23 -0700, Matthew Hernandez wrote:
> >>>> This is my first extension I'm working on. I'm trying to make a clas=
s
> >>>> available to the user space with 1 private property that is an array=
.
> >>>
> >>> The first question is: Why? - Why add the overhead of creating such a=
n
> >>> array if it is private? In most cases it is better to extend the
> >>> zend_object in C (struct my_object { zend_object inner; type
> >>> some_data;}) to hold private data. If you want to show it in var_dump
> or
> >>> a debugger you could implement a debug_info hook.
> >>>
> >>> johannes
> >>>
> >>>
> >>>
> >>
>

--14dae9399c5dd6fe7e04bd251caa--