Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:59449 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2320 invoked from network); 8 Apr 2012 00:38:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Apr 2012 00:38:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.163 smtp163.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.163] ([67.192.241.163:57126] helo=smtp163.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id ED/21-29109-91ED08F4 for ; Sat, 07 Apr 2012 20:38:50 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp6.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 3CD3C270C70; Sat, 7 Apr 2012 20:38:47 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp6.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id E1C96270A97; Sat, 7 Apr 2012 20:38:46 -0400 (EDT) Message-ID: <4F80DE16.1020407@sugarcrm.com> Date: Sat, 07 Apr 2012 17:38:46 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Gustavo Lopes CC: "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: Addition of calendar to intl From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > I have exposed ICU's Calendar API to PHP via the intl extension. It allows > date calculations with Gregorian, Chinese, Coptic, Ethiopic, Hebrew, > Indian, Islamic (civil/religious), Japanese, Persian, Taiwan and Thai > Buddhist calendars. For a broader overview of its functionality, see: > > http://icu-project.org/apiref/icu4c/classCalendar.html Thank you for you work! On the procedural note, I think it would be much better to follow the procedure like this: 1. Talking to extension maintainer 2. Submitting RFC 3. Announcing on the list 4. Publishing the implementation branch 5. Hopefully, review & improvement 6. Commit I hope the times of "commit huge patches first, discuss them and document later if ever" are behind us. Or at least we should try to put them behind us. As for the API, I'm not sure I understand properly what it is supposed to do (one of the downsides of no RFC). Is it for date calculations? What kinds of calculations you could do? What is IntlGregorianCalendar class - and why there is Gregorian one, but not others? If I wanted to work with Hebrew calendar, how would I do that? What does it do that DateTime doesn't? For the timezones - what is the difference between these timezones and the ones DatTime has - is there something additional that these provide? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227