Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:59344 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81260 invoked from network); 3 Apr 2012 10:47:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Apr 2012 10:47:46 -0000 Authentication-Results: pb1.pair.com header.from=jason.gerfen@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jason.gerfen@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender) X-PHP-List-Original-Sender: jason.gerfen@gmail.com X-Host-Fingerprint: 209.85.215.42 mail-lpp01m010-f42.google.com Received: from [209.85.215.42] ([209.85.215.42:51340] helo=mail-lpp01m010-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7E/04-54877-055DA7F4 for ; Tue, 03 Apr 2012 06:47:46 -0400 Received: by mail-lpp01m010-f42.google.com with SMTP id l5so4554306lah.29 for ; Tue, 03 Apr 2012 03:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=7qdTKfL/wPQX8VyQstoExqtsD1VXuLstdk5cffXuOvU=; b=HOxoPw+zPEaM1vfP5widX/AyBVv/MSHg9eKSqW9Q1YcKYNS2zsLLqBPstK+RzPNXlJ OQVT7K4QMU+1F7fCcCf/1/6XGVkGgzQ/h347Oni3AO6yLwhuWn3ORci9/LC4jWFK6EBp 978YRu0PO9Nbqn7otE88xLuoXZbkPnP2+4l/665XwDpVaWwbj/pYaU7qPXMUjXoq1L9Z rqRqPRdvplOj6RLex+sr30JFtGJkMgAthCUB4J/Jcaq0jOiawkEjj462xczUExhLsJHH BMfxfRzO7jXz6Ux02ozFrkkWtH6l7Z753wzWlz6YM+bzzhpYMZtfpA4a1eEjzUgA3EvJ bvVw== MIME-Version: 1.0 Received: by 10.152.103.239 with SMTP id fz15mr13421986lab.42.1333450064526; Tue, 03 Apr 2012 03:47:44 -0700 (PDT) Received: by 10.112.82.162 with HTTP; Tue, 3 Apr 2012 03:47:44 -0700 (PDT) Date: Tue, 3 Apr 2012 04:47:44 -0600 Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary=f46d04088e9f6bfe4f04bcc4098f Subject: Push Request #21 From: jason.gerfen@gmail.com (Jason Gerfen) --f46d04088e9f6bfe4f04bcc4098f Content-Type: text/plain; charset=ISO-8859-1 Please bear with me as I am going to address a few things that (being new) I seem to have over looked upon my initial pull request @ https://github.com/php/php-src/pull/21. I have forked and submitted a push request to add native spkac functionality per a feature request @ https://bugs.php.net/bug.php?id=38917. It introduces five new functions: openssl_spki_new() openssl_spki_export() openssl_spki_export_challenge() openssl_spki_verify() openssl_spki_details() First I am not sure I should include the openssl_spki_details() function as it may be overkill and the remainder of the PHP OpenSSL extension does not have anything providing the modulus and other details. I am leaning towards the omitting of this in next pull request. Second. The warning message UC first or all LC has been brought up. The remainder of the warnings messages do not use LC at all and I simply followed this example. Third. The adherence to C89 vs. C99 functions, I could not find references to this in any of the internals docs. I very well could have missed it. Fourth. A couple of you made mention of re-factoring to omit goto statements. Does this mean the remainder of the ext/openssl/openssl.c file should be re-factored as I originally used this as an example of creating new functions which does include a few functions making use of goto statements. Thanks for any feedback you can provide -- Jas --f46d04088e9f6bfe4f04bcc4098f--