Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:59211 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96930 invoked from network); 30 Mar 2012 00:36:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Mar 2012 00:36:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.143 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.143 smtp143.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.143] ([67.192.241.143:47172] helo=smtp143.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/BA-40808-C10057F4 for ; Thu, 29 Mar 2012 19:36:45 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp14.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id E87D12981F7; Thu, 29 Mar 2012 20:36:41 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp14.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id A13602981E1; Thu, 29 Mar 2012 20:36:41 -0400 (EDT) Message-ID: <4F750019.10806@sugarcrm.com> Date: Thu, 29 Mar 2012 17:36:41 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Ferenc Kovacs CC: Alexey Shein , PHP Internals References: <4F74DFF6.7010507@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Change all XFAIL tests to FAIL From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > could you elaborate on this part? where were we a year ago? We had many failing tests that now XFAILs classified as regular FAILs. > yeah, but as we did see, the current approach makes it very easy to > "hide" even the not so small issues (for example the bunch of date > related XFAILS which you personally asked multiple times to be fixed > before the 5.4 release). And did that happen while they were FAILs? No, it did not. These fails were still ignored. > I think that in it's current form XFAIL hurts more than it helps. Hurts what? What is worse than before? Every problem you describe we had before, and on top of that we have ones that we don't have now. > I think that eliminating the failing tests and making the fails noisy > would be a better approach. Better in which regard? We know for a fact that having test fails does not lead to people promptly fixing it. We just have 50 test failures for a year, and people stop regarding 50 test failures as something exceptional - we always had tons of test fails, who cares if there's one or two or ten more? So if you propose going back to what we already had a year ago, you still have to explain how situation would be better than it was a year ago - what exactly changed? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227