Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59148
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CAF+90c_YZvtmQ=VadKuJ4XkTXZmKCKdm=+Zp8ga54AoOBPhkwQ@mail.gmail.com>
References: <CAF+90c_YZvtmQ=VadKuJ4XkTXZmKCKdm=+Zp8ga54AoOBPhkwQ@mail.gmail.com>
Date: Sat, 24 Mar 2012 21:32:28 +0800
Message-ID: <CABBJUpfd3uQteYEvfBsqht=3S4kky_KYeL2POWdGyEZ1gSN1pw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@googlemail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] set_error_handler and set_exception_handler behavior
From: laruence@php.net (Laruence)

On Sat, Mar 24, 2012 at 9:26 PM, Nikita Popov <nikita.ppv@googlemail.com> w=
rote:
> Hi internals!
>
> Laruence and myself yesterday tried to slightly modify the
> set_error_handler behavior, but the change which we considered trivial
> was not perceived as such by others. So we are taking this to the ML.
>
> Current state of things:
> =C2=A0* set_error_handler(callback) and set_exception_handler(callback)
> will return the previous error/exception handler
> =C2=A0* set_exception_handler(NULL) will reset the exception handler (i.e=
.
> use the default PHP exception handler again) and return bool(true)
> =C2=A0* set_error_handler(NULL) throws an invalid argument error =3D> inc=
onsistent
>
> What we wanted to do:
> Allow the error handler being reset using set_error_handler(NULL). To
> be consistent with set_exception_handler(NULL) this was supposed to
> return bool(true).
>
> What people objected to:
> =C2=A0* Stas: The bool(true) return value does not really make sense.
> Instead the previous error/exception handler should be returned, as
> always.
> =C2=A0* Pierre: One shouldn't be able to reset the error/exception handle=
r
> like that in any case. This behavior should be removed and instead
> there should be additional reset_error_handler() and
> reset_exception_handler() functions (and also get_error_handler() and
> get_exception_handler() if I got that right.)
>
> What I would do:
> =C2=A0Add support for set_error_handler(NULL) and change the return value
> of set_error_handler(NULL)+set_exception_handler(NULL) to the previous
> handler (i.e. Stas option). I implemented this option in this PR:
> https://github.com/php/php-src/pull/20
>
> So, what are your opinions on this?
I was plan to explain why, but you described very well :)

thanks
>
> Nikita
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/