Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59086
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.117 cause and error)
Message-ID: <4F68D7B4.4030305@oracle.com>
Date: Tue, 20 Mar 2012 12:17:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120129 Thunderbird/10.0
MIME-Version: 1.0
To: Osama Abu Elsorour <osama.sorour@eformations.net>
CC: internals@lists.php.net
References: <11302143-55E0-48E9-AC30-943E6075E794@eformations.net>
In-Reply-To: <11302143-55E0-48E9-AC30-943E6075E794@eformations.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] readline extension bug fixes and enhancements
From: christopher.jones@oracle.com (Christopher Jones)



On 03/20/2012 12:06 PM, Osama Abu Elsorour wrote:
> All,
>
> I was recently involved in a project that relied heavily on readline to provide console text input capabilities. However I soon noticed that the current readline extension has a serious bug and is lacking some important functionality.
>
> This patch applies only to PHP compiled with libreadline (and don't have an effect if compiled with libeditline). It adds/modifies/fixes the following:
> - Fixes memory corruption caused by directly setting rl_line_buffer to new buffer and not using rl_replace_line().
> - Fixes a bad combination of preprocessor #if that would cause readline_on_new_line() implementation not to compile when using libreadline only.
> - Adds support for rl_bind_key function by exposing:
> function readline_bind_key_function($key, $callback_func)
> where:
> $key: Key code to bind to.
> $callback_func: A callback function in the form:
> function callback($key, $count) where $key and $count are the same parameters passed from rl_bind_key()
> Setting $callback_func to null will cause the binding to be removed for $key.
> - Modifies the behavior of readline_info() to allow for setting the readline properties "point" and "end" (it used to only read them but not set them).
>
> Patch below:

To avoid your patch getting lost in the mail archives, what about trying out the new github integration?: https://wiki.php.net/vcs/gitworkflow#workflow_for_external_contributors
Or log a bug (https://bugs.php.net/) and attach the patch.

Chris

-- 
Email: christopher.jones@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/