Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:59077 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4531 invoked from network); 20 Mar 2012 12:43:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Mar 2012 12:43:53 -0000 Authentication-Results: pb1.pair.com header.from=francois.gannaz@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=francois.gannaz@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender) X-PHP-List-Original-Sender: francois.gannaz@gmail.com X-Host-Fingerprint: 74.125.82.170 mail-we0-f170.google.com Received: from [74.125.82.170] ([74.125.82.170:50971] helo=mail-we0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 71/60-01174-88B786F4 for ; Tue, 20 Mar 2012 07:43:53 -0500 Received: by werh12 with SMTP id h12so7984416wer.29 for ; Tue, 20 Mar 2012 05:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:x-mailer:mime-version:content-type :content-transfer-encoding; bh=srDbvGU3T2FzxNE7d/1ByhHjYSV6TV7q982mZ7vdAEE=; b=mT4wVPNpD5blvmR7wSnFeJer7aM0TQKsKJiEUl2khw8C/IA7OCFLzKsrcKtxC5Lq4/ eCwNBpeyYVlfcqGaciyCbcxghLfwE9W5ONeg+SauRgCKwx8n7k/p7rT1YLWoDwsl40qB kVrOr3/Eq3v3rUnBPQyVGLipMH1mfSvQ6u8gyb3xXruA5nVhSHUU9NqBv2dkwEmYGoKB mCC1b5c1oCyd1MfABiNpovG8UpFC0nLekjDx9cgw75Ttmvpr6QMAXezYKKaDeAi9JlIH zHxFvUh0wypXyjRKQdpM0Fu1AJFBN3Fg1eDruqmWaELAnbCHpE3UuolqBITG9/7CzHm/ Q+DQ== Received: by 10.180.107.164 with SMTP id hd4mr28352677wib.18.1332247430367; Tue, 20 Mar 2012 05:43:50 -0700 (PDT) Received: from coriolan (lear.silecs.info. [88.172.133.112]) by mx.google.com with ESMTPS id k6sm33755448wie.9.2012.03.20.05.43.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Mar 2012 05:43:49 -0700 (PDT) Date: Tue, 20 Mar 2012 13:43:48 +0100 To: internals@lists.php.net Message-ID: <20120320134348.654b3b03@coriolan> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Fixing a bug : a personal report From: francois.gannaz@gmail.com (=?ISO-8859-1?B?RnJhbudvaXM=?= Gannaz) Hi I wrote a report of my first dive into php-src in an attempt to fix a bug. https://github.com/mytskine/php-src/wiki/bug40531-mbsubstr I tried to detail everything as a personal memo, then for a friend of mine, and now I've put it into a github wiki page. I wonder if it can be useful to anyone. If you have the time to read it, I'm very interested in any comments, especially on the technical parts (integer= s, null values and zval). Please don't be to harsh if I misunderstood somethin= g. Regards -- Fran=E7ois Gannaz