Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:59020
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 213.123.20.128 cause and error)
Message-ID: <4F664543.5000709@lsces.co.uk>
Date: Sun, 18 Mar 2012 20:27:47 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Firefox/10.0.2 SeaMonkey/2.7.2
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <4F65A77F.3010001@lsces.co.uk> <4F65C87A.70703@thelounge.net> <4F6604DC.4040308@lsces.co.uk> <CAH-PCH5S1S_Q1=hw9XGJfGwcQqjJRjUqsXKGHHPyAjtfjzywEA@mail.gmail.com> <4F662115.1040000@lsces.co.uk> <CAF+90c9g3ieNgYXFJuxkMg7FHsB2HUGUaWOnS9gKWmLOZSpB5Q@mail.gmail.com>
In-Reply-To: <CAF+90c9g3ieNgYXFJuxkMg7FHsB2HUGUaWOnS9gKWmLOZSpB5Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP5.4 'nannying'
From: lester@lsces.co.uk (Lester Caine)

Forgot the pigging reply all :(

Nikita Popov wrote:
> On Sun, Mar 18, 2012 at 6:53 PM, Lester Caine<lester@lsces.co.uk>  wrote:
>> >  [...] SO my original question still applies, but for different
>> >  reasons ... is there a crib sheet to help eliminate strict code errors in
>> >  legacy code bases?
> Uhm, I'm not sure whether I am completely stupid and miss something
> obvious: But what exactly is the problem with just reading the error
> messages and fixing the errors they report? I mean, you get the reason
> for the error and the line which causes it, so what is the problem
> with going to that line and fixing that error?

Nikita and others ...

Yes I can quite happily go through and fix each error as it appears and over a 
few weeks the errors will have reduced, but that is not fixing the problem that 
'modern' strict rules on coding style is somewhat different to how code WAS 
written 10 years ago. I'd rather FIX the code base so that it follows how 
E_STRICT expects the code to be written which I think needs a fairly major 
rewrite of some of the core code base. I think ADOdb needs a rework as well as 
other major libraries I am using which just adds to the hassle.

The alternative is simply to bury my head again as has been suggested and force 
E_STRICT off in 5.4. But if I can't simply write code that IS 'complaint' in the 
first place because I don't have any guide to work to how do we expect newcomers 
to get their heads around the subtleties. They simply follow samples from old 
tutorials which have exactly the same problems I'm trying to solve myself :(

( I'll move the problem of how the heck one fixes the dozens of "Array to string 
conversion in" notices to the general list ... I'm seeing hundreds of reports of 
these on the net now that 5.4 is rolling out .. )

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php